Desugaring fixes #1369
Merged
Desugaring fixes #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emporary variable * See ruby#1329 (comment) for details.
* Consistent with ClassVariableWriteNode, ConstantWriteNode, InstanceVariableWriteNode, LocalVariableWriteNode. * Fixes desugaring of global variable with operators.
* Consistent with ClassVariableWriteNode, ConstantWriteNode, InstanceVariableWriteNode, GlobalVariableWriteNode. * Fixes desugaring of local variable with operators.
eregon
force-pushed
the
desugaring-fixes
branch
from
45c1aa5 to
3ef460d
Compare
kddnewton
requested changes
Aug 30, 2023
eregon
force-pushed
the
desugaring-fixes
branch
from
3ef460d to
7b090bc
Compare
kddnewton
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some nodes were incorrectly desugared, with some location field and the value nodes being swapped.
This is fixed by making the ordering consistent in this PR.
If that's not desired, an alternative would be to provide lambdas to helpers like
desugar_or_write_nodeto get the correct order (that can also be done in addition to making the order consistent).