[DRAFT] - Add copy command #1044
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prajjwal
force-pushed
the
sin.add-copy-command
branch
from
565421b to
7affd25
Compare
st0012
reviewed
Dec 12, 2024
| HELP | ||
|
|
||
| def execute(arg) | ||
| output = irb_context.workspace.binding.eval(arg) |
There was a problem hiding this comment.
I think we need to apply the output inspection method here so the copied output will be closer to what the users may expect.
For example, the output here by default will be the to_s result of the evaluation result, but IRB's default output inspector pretty prints the result inspect.
Additionally, we need to make sure colorizing is NOT applied to the copied value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #753