You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would be very happy if you could update the Docker images provided by ghcr.io and Docker Hub along with the Dockerfile update (merge to base branch) of this repository.
I think it would have the following benefits.
No more differences between the Docker images provided and the Dockerfile in this repository.
The base Ubuntu image and packages will also be updated.
If you agree with the proposal, I can send you a pull request.
Specifically, I will use the on.push event and the build matrix
The text was updated successfully, but these errors were encountered:
k1LoW
changed the title
Updating Docker images at the same time as updating the Dockerfile
Update Docker images at the same time as updating the Dockerfile
Mar 18, 2021
I think updating images automatically triggered by Dockerfile change is not acceptable.
Before updating images, we should consider what ruby versions are the targets for the change in many cases.
Currently, images for the release versions are built by manually launched workflows just after releasing these versions of ruby.
Before updating images, we should consider what ruby versions are the targets for the change in many cases.
Indeed, I think it is an important consideration.
On the other hand, I think it would be better if there is some way to solve the issue of the difference between the Dockerfile in the repository and the Docker image provided, or the issue of the vulnerability left in the Docker image.
ubuntu:* which is used by ruby-docker-images, seems to be updated regularly.
Perhaps resolving a vulnerability is one reason.
For example, how about running tests on the built Docker image before releasing it, and releasing it only if it passes?
The tests are the same ones that you check before releasing an image.
However...
I understand what you are saying.
If you find it difficult to accept the proposal (a release with testing), you can close this issue.
Hi Team. Thanks for maintaining the images!
I would be very happy if you could update the Docker images provided by ghcr.io and Docker Hub along with the Dockerfile update (merge to base branch) of this repository.
I think it would have the following benefits.
If you agree with the proposal, I can send you a pull request.
Specifically, I will use the
on.push
event and the build matrixThe text was updated successfully, but these errors were encountered: