Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple calls to attributes shouldn't result in multiple definitions of methods for accessors, equality, etc. #2

Open
louismrose opened this issue Apr 11, 2014 · 0 comments

Comments

@louismrose
Copy link
Member

The following example:

class Person
  extend Attributable
  attributes :name
end

class Employee < Person
  attributes :salary
end

Defining Employee results in two calls to Attributable#add_instance_methods and hence Attributable's define_method logic is called twice (once with attributes = {name: nil} and once with attributes = {name: nil, salary: nil}).

It seems redundant to add these methods more than once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant