-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isnt the switchboard supposed to emit the peer /announce commands as announce to rtc-switch? #25
Comments
Hi @magestican - I'm not sure I've quite understood your question but I'll take a crack at it. The You can see this in action in Does that answer your question? |
Hey nathan! I was not expecting an answer so this was a placeholder question :D. Rtc-signal as well as rtc-signaller and rtc-quickconnect are all client side, but rtc-switch is server side and there is no server side library which emits the "announce" event on the server. rtc-switch is an EventEmitter object right, there is no .emit on that object thats what I am saying, or at least I cant find it, the only thing I can think of is to listen on the "data" event of the peer and manually do rtcSwitch.emit("announce") when the data of the data event contains "/announce". |
Hi Bryan, Thanks for clarifying the question - I wasn't sure whether you were asking about client side stuff, and just happened to be in a server side library issue :)
So if you want to listen in for announce messages, you can simply use You can see rtc-switch uses this logic to handle the room assignment at https://github.com/rtc-io/rtc-switch/blob/master/index.js#L117. Hope that helps. |
I see now that the switch parses all the commands and emits them, that was not clear to me, thanks. |
I have seen that the signaller will send an /announce command as part of the data event to the server (switchboard) but none of your libraries seem to emit the announce event handler declared on rtc-switch.
Any ideas?
The text was updated successfully, but these errors were encountered: