From 3558abdc9a388408948bf537bbd684b27255de89 Mon Sep 17 00:00:00 2001 From: Silvia Pfeiffer Date: Thu, 15 Sep 2016 16:14:18 +1000 Subject: [PATCH 1/3] Added options documentation for issue #46 --- README.md | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 1d56645..5fe3d63 100644 --- a/README.md +++ b/README.md @@ -30,6 +30,10 @@ quickconnect('https://switchboard.rtc.io/', { room: 'qc-simple-demo' }) ``` +The first argument to quickconnect is the URL of the signalling server, the second is a set of options given as a JSON object. +Valid options are described [below](#valid-quick-connect-options). + + ## Events The following events are emitted from the signalling object created by calling `quickconnect()`. Additionally, any of the underlying [signaller events](https://github.com/rtc-io/rtc-signaller#signaller-events) can also be used. @@ -242,6 +246,12 @@ Listed below are some of the commonly used options: - `debug` (default: false) +- `plugins` (default: '') + + An optional array of rtc-plugins to add, e.g. add Temasys plugin as list + item `plugins = [ require('rtc-plugin-temasys')];` + + Write rtc.io suite debug output to the browser console. - `expectedLocalStreams` (default: not specified) _added 3.0_ @@ -265,8 +275,15 @@ function: - `iceServers` -This provides a list of ice servers that can be used to help negotiate a -connection between peers. + This provides a list of ice servers that can be used to help negotiate a + connection between peers. + +- `constraints` (default: '') + + An optional RTCConstraints object that is handed to the , e.g. + constraints: {"optional": [ {'googIPv6': 'false'} ] } or + constraints: {"optional": [ {RtpDataChannels: true} ] } + #### Options for P2P negotiation From 3a91c6879ec919b7fad24b97eb5bb3e1016ecce8 Mon Sep 17 00:00:00 2001 From: Silvia Pfeiffer Date: Thu, 15 Sep 2016 16:16:19 +1000 Subject: [PATCH 2/3] Improve display of last committed fixes. --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 5fe3d63..4035d88 100644 --- a/README.md +++ b/README.md @@ -280,9 +280,9 @@ function: - `constraints` (default: '') - An optional RTCConstraints object that is handed to the , e.g. - constraints: {"optional": [ {'googIPv6': 'false'} ] } or - constraints: {"optional": [ {RtpDataChannels: true} ] } + An optional RTCConstraints object that is handed to the RTCPeerConnection call, e.g. + `constraints: {"optional": [ {'googIPv6': 'false'} ] }` or + `constraints: {"optional": [ {RtpDataChannels: true} ] }` #### Options for P2P negotiation From 559c6c3b1af9939811b5c6ff55ea5d3589f7c90d Mon Sep 17 00:00:00 2001 From: Silvia Pfeiffer Date: Thu, 15 Sep 2016 16:27:18 +1000 Subject: [PATCH 3/3] Adding SDP munging example also to address issue #18 --- README.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/README.md b/README.md index 4035d88..f744aa8 100644 --- a/README.md +++ b/README.md @@ -284,6 +284,11 @@ function: `constraints: {"optional": [ {'googIPv6': 'false'} ] }` or `constraints: {"optional": [ {RtpDataChannels: true} ] }` +- `sdpfilter` (default '') + + An optional function to provide for sdp munging, e.g. + `sdpfilter: function(sdp) { console.log('filtering sdp'); return limitBandwidthSDP(sdp);}` + #### Options for P2P negotiation