Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move steps in pull-shared-core.sh to language with proper regex support #55

Open
bschwedler opened this issue Feb 11, 2022 · 1 comment
Labels
launcher Related to the launcher

Comments

@bschwedler
Copy link
Contributor

bschwedler commented Feb 11, 2022

The current process of creating a new SDK release process pulls in the shared_core library from the rstudio repo. Various modifications are made to these files using regexes and sed.

It would be beneficial to move this into a language that has full regex support as part of its standard library. This will allow modification of the files in memory as well as having the following additional benefits:

  • Named match groups in regex patterns
  • Multi-line regexes
  • lookahead/lookbehind assertions
  • Saving compiled regex to variables
  • Combining already-defined regexes into more complex patterns

This should result in more flexibility as well as improved readability and maintainability.

@bschwedler
Copy link
Contributor Author

bschwedler commented Feb 11, 2022

I am partial to python's re module, which has support for all the previously mentioned benefits. While it is definitely more verbose than the regex support in perl or ruby I have personally found that because it is more explicit it can be easier to follow for newcomers to regexes.

@bdeitte bdeitte added the backlog label Mar 4, 2022
@bdeitte bdeitte removed the backlog label Jul 7, 2022
@bschwedler bschwedler added the launcher Related to the launcher label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
launcher Related to the launcher
Projects
None yet
Development

No branches or pull requests

2 participants