Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1-based indexing to return values #1321

Closed
wants to merge 3 commits into from

Conversation

mohamed-180
Copy link

Related to #1318

@t-kalinowski
Copy link
Member

Thank you!
Can you please also update the roxygen docs (e.g., by inserting "(1-based)" where appropriate) and also a note in the NEWS?
If you're planning to also update the others listed in #1318, a simple as_axis() callback should be all that's needed for each of them (along with news and docs updates)

@t-kalinowski
Copy link
Member

Thank you for the PR!

Changing indexing in keras was too much of a breaking change. This was deferred and implemented in the new package {keras3}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants