Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save JSON representation of HTML dependencies & underlying Sass code #915

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Nov 21, 2023

This PR is motivated by Quarto (which already takes a build-time dependency on bslib to copy over it's modified version of Bootstrap) wanting to leverage even more work that we're doing in Sass (especially the bs_theme(preset="shiny")).

The main idea/addition here is a new inst/css-precompiled/5/dependencies.json file that Quarto can ingest to:

  1. Check/monitor jQuery/Bootstrap versions.
  2. Ensure its Bootstrap Sass layer faithfully matches ours.
  3. Decide how/whether to include the additional Sass layers that we include by default with our Bootstrap HTML dependency (i.e., the bslib, bs3compat, and builtin) are worth adding.
    • It's probably fine to include all these, but also keep in mind that at bs3compat also comes with JS assets (those assets would make it so shiny::tabsetPanel(), which produces BS3 markup, works correctly in Quarto)
    • See the section below for getting other details right, such as fonts for the builtin.
  4. Decide whether it's worth compiling bslib's component Sass code, rather than relying on bslib to provide the pre-compiled CSS
    • I don't think this is worth doing at the moment, and hopefully we don't have a real need for it in the future (we're hoping we can leverage Bootstrap's CSS variables in such a way that they'll still feel theme-able via Sass).

Other, more general, things Quarto should be aware of:

  • All of the relative file paths in dependencies.json are relative to bslib's inst/ directory.
  • Some layers use sass_layer() features that probably don't exist in Quarto, such as file_attachments, which are essentially just extra files/directories that get imported inside the Sass code/files.
  • Some of these HTML dependencies have all_files = TRUE, which mounts the entire {src: file: {}} directory at name-version. This what makes things like source map files available and the $web-font-path: "font.css" trick that builtin and bootswatch themes leverage to implement local file requests (in that case, there is a @import font.css which makes a request to font files under the font/ directory).

BTW, there are, what seems to be a lot of R/scss changes in this PR, but it's mostly just shuffling logic around so it's more centralized and simpler to get a sass_bundle() representation of bs_theme() that is just 4 layers: bootstrap, bslib, bs3compat, and builtin.

@cpsievert cpsievert marked this pull request as ready for review November 21, 2023 23:01
@cpsievert cpsievert requested a review from gadenbuie November 21, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants