-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream? StableSet: Adding an additional implementation, new features and tests and more. #91
Comments
Hi, would you mind supporting this too #79? |
The refactor's elimination of the list is a significant improvement. The ordering preserved by the interface for intersection is also an improvement. FYI, You can make I also don't see the point of |
@twiddli pretty sure he can't support it since dicts don't have efficient indexing. |
@twiddli @NeilGirdhar |
@idanmiara a few questions.
|
@jagerber48 thanks, I'll look into it when I'm back from my holiday. |
Hi @rspeer
Thanks for this nice library!
I made a very large refactor, added another implementation, many features, tests and compatibility with other implementations and some more. The new version passes all the tests from the other 3 repositories almost completely unchanged.
https://github.com/idanmiara/ordered-set
Since that's a major addition, I didn't know how/if you would want to merge this work and since I needed to use this for some project already - I released it under to pypi under a new name
stableset
(with proper credits).Having said that, I'd be happy to merge this work upstream if you are interested, if so, let me know how you'd like to proceed with this.
The text was updated successfully, but these errors were encountered: