From 6f6282734590b86f71dc44b69c5537e864bd8f12 Mon Sep 17 00:00:00 2001 From: Wilmer Rondon Date: Mon, 24 Jun 2024 15:06:53 -0400 Subject: [PATCH] Adding a comment to make clearer the use of currentFeePerKb variable. Removing Unnecessary Comment Removing Unnecessary Vote - Removing unnecessary vote since it doesn't help to go straight to the point to the sense of the test method. --- .../src/test/java/co/rsk/peg/feeperkb/FeePerKbIT.java | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/rskj-core/src/test/java/co/rsk/peg/feeperkb/FeePerKbIT.java b/rskj-core/src/test/java/co/rsk/peg/feeperkb/FeePerKbIT.java index 031e61e2091..f4f2a27ec81 100644 --- a/rskj-core/src/test/java/co/rsk/peg/feeperkb/FeePerKbIT.java +++ b/rskj-core/src/test/java/co/rsk/peg/feeperkb/FeePerKbIT.java @@ -27,7 +27,7 @@ class FeePerKbIT { private final FeePerKbConstants feePerKbConstants = FeePerKbMainNetConstants.getInstance(); private FeePerKbSupport feePerKbSupport; private SignatureCache signatureCache; - private Coin currentFeePerKb; + private Coin currentFeePerKb; // it is used to guarantee the value from getFeePerKb() contains the value expected @BeforeAll void setUp() { @@ -465,12 +465,7 @@ void voteFeePerKbChange_whenVotingSameCurrentFeePerKbValue_shouldSetValueVoted() //It still has the previous voting round value assertFeePerKbValue(currentFeePerKb); - // Second vote for a different value, different authorizer - voteFeePerKb(differentFeePerKbVote, FeePerKbVoteCaller.SECOND_AUTHORIZED.getRskAddress()); - //It still has the previous voting round value - assertFeePerKbValue(currentFeePerKb); - - // Third vote from authorizer 3, same value as the first one voted from authorizer 1 + // Second vote from authorizer 3 is the same as first vote voteFeePerKb(sixteenthFeePerKbVote, FeePerKbVoteCaller.THIRD_AUTHORIZED.getRskAddress()); currentFeePerKb = sixteenthFeePerKbVote;