Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork wunditta/MIDI2LR #746

Closed
wunditta opened this issue Sep 23, 2023 · 9 comments
Closed

Fork wunditta/MIDI2LR #746

wunditta opened this issue Sep 23, 2023 · 9 comments

Comments

@wunditta
Copy link

wunditta commented Sep 23, 2023

Currently it is very difficult to decide how to proceed with this project. I started with my fork wunditta/MIDI2LR to iron out some smaller issues and some little changes. But now I am afraid it gets out of hands. Before it can or never will be accepted to join with this repository I urgently would need some feedback from you, rsjaffe.

What are your plans with this? Will you maintain it further? If so, do you see any chance to join our forks? I am willing to contribute in any helpful way. I could also undo some changes and add them step by step.

One of the major issues is, that I am now moving most functions from Profiles to ClientUtilities as there were functions in each requesting functions from the other (after I added some features). I am afraid that soon it will be impossible to join both forks. This change is not reflected on Git so far, only locally. But as I will fix some bugs with the current pre-release I will have to upload that as well.

@antzpantz
Copy link

antzpantz commented Sep 23, 2023 via email

@rsjaffe
Copy link
Owner

rsjaffe commented Sep 23, 2023

I hope to join the forks sometime soon. I stepped away because I was getting burnt out with some of the more obscure bugs and wasn't getting any help. Now that you're working on it too, I feel better about getting back. I should do so within a month (can't get to it until then). Still need significant help with Mac Silicon processor peculiarities as I don't have a machine set up to debug that processor.

@antzpantz
Copy link

antzpantz commented Sep 23, 2023 via email

@wunditta
Copy link
Author

I hope to join the forks sometime soon. I stepped away because I was getting burnt out with some of the more obscure bugs and wasn't getting any help. Now that you're working on it too, I feel better about getting back. I should do so within a month (can't get to it until then). Still need significant help with Mac Silicon processor peculiarities as I don't have a machine set up to debug that processor.

Very nice to hear from you :-) . I really hope I did not mess things up in an uncontrollable way... ;-)

Just for reference, this are the issues which should be solved with my fork:

@rsjaffe
Copy link
Owner

rsjaffe commented Nov 30, 2023

I'm now actively working on the update. It's going to take a while because there's a lot to do. I try to use Lightroom's translation strings when possible. If I can't for some of the additions, I'll have to work on the translations, which may delay those feature's inclusion. I don't include any un-localized strings, as there are lots of non-English speakers using this application.

@rsjaffe
Copy link
Owner

rsjaffe commented Dec 5, 2023

6.0 is out for testing (see discussion forum). It has some of your simpler updates. I am slowly reviewing the other ones for possible future release.

@rsjaffe
Copy link
Owner

rsjaffe commented Dec 5, 2023

Undoing some of the changes I haven't yet included and reintroducing them step-by-step would help greatly.

Normally when I'm developing a new feature, I commit all the changes for that specific feature as a single commit, with all the changes in the affected files included. That way, it is much easier to understand the changes and correct issues as they arise.

Thanks again for your work!

@rsjaffe rsjaffe closed this as completed Jan 31, 2024
@wunditta
Copy link
Author

wunditta commented Feb 1, 2024 via email

@rsjaffe
Copy link
Owner

rsjaffe commented Feb 1, 2024

Probably not. I've gone on from there a long ways, am currently working on a way to allow fine adjustments that integrates with current methods and am close to a beta test release. Thanks for your work, and after the next release, feel free to fork and work on it some more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants