Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make support for EE6 #68

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Make support for EE6 #68

wants to merge 17 commits into from

Conversation

benya
Copy link

@benya benya commented Jan 14, 2021

Make support for EE6

@litzinger
Copy link
Collaborator

This isn't my repo, so take this with a grain of salt, but if you're doing a PR into someone else's repo, then I would think the addon.setup.php file should retain the original author information. Perhaps in a comment you can add something like "Updated for EE version X by [name]"

I would also suggest squashing this into a single commit so the merge is cleaner. I don't see the need having 14 separate commits in the timeline.

@Zignature
Copy link

Zignature commented Jan 14, 2021

This isn't my repo, so take this with a grain of salt, but if you're doing a PR into someone else's repo, then I would think the addon.setup.php file should retain the original author information. Perhaps in a comment you can add something like "Updated for EE version X by [name]"

I would also suggest squashing this into a single commit so the merge is cleaner. I don't see the need having 14 separate commits in the timeline.

Hi there Brian,

I did mention the original author in addon.setup.php at the top of the code in the commented area.
If this is insufficient or incorrect, I apologize. I've seen it in other forks, so I thought it was the proper way.

I'm not very Github-savvy. As can be seen by the number of commits. Whenever I thought the readme was finished , I came up with a change. Again, I apologize.

By the way, it wasn't me that did the PR :)

@Zignature
Copy link

Zignature commented Jan 14, 2021

Make support for EE6

I'll try. There were some radical changes in the way EE6 handles custom fields in the database.
Since I'm just a "hobby programmer" it might take me some time...

@Zignature
Copy link

do not merge the abovementioned commits. There are mistakes in them. They were made on upgraded versions of ExpressionEngine with legacy data and legacy database tables.

I'm working on a versions created on fresh installs of EE4 (pretty much done, and should work on EE5 as well) and EE6.

@Zignature
Copy link

Try this: v3.0.0 JSON Output for EE6

@Zignature
Copy link

Reworked code for EE4, EE5 and EE6 compatibility: v2.5.0 JSON Output for EE4, EE5 & EE6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants