Fix column length for erlang stdlib functions

lib/credo/check/warning/lazy_logging.ex

@@ -51,7 +51,8 @@ defmodule Credo.Check.Warning.LazyLogging do
          issue_meta
        )
        when fun_name in @logger_functions do
-    issue = find_issue(fun_name, arguments, meta, issue_meta)
+    trigger = "Logger.#{fun_name}"
+    issue = find_issue(fun_name, arguments, meta, issue_meta, trigger)
 
     {ast, add_issue_to_state(state, issue)}
   end
@@ -62,7 +63,7 @@ defmodule Credo.Check.Warning.LazyLogging do
          issue_meta
        )
        when fun_name in @logger_functions do
-    issue = find_issue(fun_name, arguments, meta, issue_meta)
+    issue = find_issue(fun_name, arguments, meta, issue_meta, fun_name)
 
     {ast, add_issue_to_state(state, issue)}
   end
@@ -89,12 +90,12 @@ defmodule Credo.Check.Warning.LazyLogging do
     {module_contains_import?, [issue | issues]}
   end
 
-  defp find_issue(fun_name, arguments, meta, issue_meta) do
+  defp find_issue(fun_name, arguments, meta, issue_meta, trigger) do
     params = IssueMeta.params(issue_meta)
     ignored_functions = Params.get(params, :ignore, __MODULE__)
 
     unless Enum.member?(ignored_functions, fun_name) do
-      issue_for_call(arguments, meta, fun_name, issue_meta)
+      issue_for_call(arguments, meta, trigger, issue_meta)
     end
   end
 

lib/credo/check/warning/leaky_environment.ex

@@ -27,6 +27,7 @@ defmodule Credo.Check.Warning.LeakyEnvironment do
     Credo.Code.prewalk(source_file, &traverse(&1, &2, issue_meta))
   end
 
+  @offset 2
   defp traverse({{:., _, call}, meta, args} = ast, issues, issue_meta) do
     case get_forbidden_call(call, args) do
       nil ->
@@ -36,6 +37,11 @@ defmodule Credo.Check.Warning.LeakyEnvironment do
         {ast, [issue_for(issue_meta, meta, trigger) | issues]}
 
       trigger ->
+        [module, _function] = call
+        len = module |> Atom.to_string() |> String.length()
+        column = meta[:column] - len - @offset
+        meta = Keyword.put(meta, :column, column)
+
         {ast, [issue_for(issue_meta, meta, trigger) | issues]}
     end
   end

lib/credo/check/warning/unsafe_exec.ex

@@ -37,7 +37,8 @@ defmodule Credo.Check.Warning.UnsafeExec do
   defp traverse({{:., _loc, call}, meta, args} = ast, issues, issue_meta) do
     case get_forbidden_call(call, args) do
       {bad, suggestion, trigger} ->
-        {ast, [issue_for(bad, suggestion, trigger, meta, issue_meta) | issues]}
+        [module, _function] = call
+        {ast, [issue_for(bad, suggestion, trigger, meta, module, issue_meta) | issues]}
 
       nil ->
         {ast, issues}
@@ -65,12 +66,17 @@ defmodule Credo.Check.Warning.UnsafeExec do
     nil
   end
 
-  defp issue_for(call, suggestion, trigger, meta, issue_meta) do
+  # offset 2 characters for the dot call and the atom syntax
+  @offset 2
+  defp issue_for(call, suggestion, trigger, meta, module, issue_meta) do
+    len = module |> Atom.to_string() |> String.length()
+    column = meta[:column] - len - @offset
+
     format_issue(issue_meta,
       message: "Prefer #{suggestion} over #{call} to prevent command injection.",
       trigger: trigger,
       line_no: meta[:line],
-      column: meta[:column]
+      column: column
     )
   end
 end

test/credo/check/warning/lazy_logging_test.exs

@@ -121,12 +121,15 @@ defmodule Credo.Check.Warning.LazyLoggingTest do
     |> to_source_file
     |> run_check(@described_check)
     |> assert_issues(fn [three, two, one] ->
+      assert one.trigger == "Logger.debug"
       assert one.line_no == 5
       assert one.column == 5
 
+      assert two.trigger == "Logger.debug"
       assert two.line_no == 6
       assert two.column == 5
 
+      assert three.trigger == "Logger.debug"
       assert three.line_no == 7
       assert three.column == 5
     end)

test/credo/check/warning/leaky_environment_test.exs

@@ -74,7 +74,7 @@ defmodule Credo.Check.Warning.LeakyEnvironmentTest do
     |> run_check(@described_check)
     |> assert_issue(fn issue ->
       assert issue.line_no == 3
-      assert issue.column == 13
+      assert issue.column == 5
       assert issue.trigger == ":erlang.open_port"
     end)
   end

test/credo/check/warning/unsafe_exec_test.exs

@@ -44,7 +44,7 @@ defmodule Credo.Check.Warning.UnsafeExecTest do
     |> run_check(@described_check)
     |> assert_issue(fn issue ->
       assert issue.line_no == 3
-      assert issue.column == 9
+      assert issue.column == 5
     end)
   end
 
@@ -60,6 +60,7 @@ defmodule Credo.Check.Warning.UnsafeExecTest do
     |> run_check(@described_check)
     |> assert_issue(fn issue ->
       assert issue.line_no == 3
+      assert issue.column == 5
       assert issue.trigger == ":os.cmd"
     end)
   end
@@ -76,7 +77,7 @@ defmodule Credo.Check.Warning.UnsafeExecTest do
     |> run_check(@described_check)
     |> assert_issue(fn issue ->
       assert issue.line_no == 3
-      assert issue.column == 13
+      assert issue.column == 5
       assert issue.trigger == ":erlang.open_port"
     end)
   end