Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with dnf_builddep_opts option #1496

Closed
azeey opened this issue Oct 31, 2024 · 2 comments · Fixed by #1497
Closed

Regression with dnf_builddep_opts option #1496

azeey opened this issue Oct 31, 2024 · 2 comments · Fixed by #1497

Comments

@azeey
Copy link
Contributor

azeey commented Oct 31, 2024

1237e2f makes "dnf4" equivalent to "dnf", but the implementation skips builddep_opts

for alt in ["dnf_command", "dnf_common_opts", "dnf_install_command",
"dnf_disable_plugins", "dnf_avoid_opts"]:
alt_opts[alt.replace("dnf", "dnf4")] = [alt]

This regression breaks build infrastructure that uses dnf_builddep_opts.

@praiskup
Copy link
Member

Indeed, good catch. Do you want to send a PR with fix, or shall I?

azeey added a commit to azeey/mock that referenced this issue Oct 31, 2024
@azeey
Copy link
Contributor Author

azeey commented Oct 31, 2024

Created #1497.

praiskup pushed a commit that referenced this issue Nov 1, 2024
@nikromen nikromen moved this from Needs triage to Done in CPT Kanban Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants