Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offline-distrosync compatible subcommands #1330

Closed
kontura opened this issue Mar 20, 2024 · 1 comment
Closed

offline-distrosync compatible subcommands #1330

kontura opened this issue Mar 20, 2024 · 1 comment
Labels
Priority: LOW RFE Request For Enhancement (as opposed to a bug)

Comments

@kontura
Copy link
Contributor

kontura commented Mar 20, 2024

Aliases for offline-distrosync and offline-upgrade don't match the dnf4 commands.
It basically changes dnf offline-distrosync download -> dnf5 offline-distrosync and discards the rest.

We do have all the functionality so I think we could build the aliases to (more or less) fit.

Something like:

['offline-distrosync']
type = 'command'
attached_command = 'distro-sync'
group_id = 'commands-compatibility-aliases'
complete = true

['offline-distrosync.download']
type = 'command'
attached_command = 'distro-sync'
complete = true
attached_named_args = [
  { id_path = 'distro-sync.offline' }
]

['offline-distrosync.log']
type = 'command'
attached_command = 'offline.log'
complete = true
...

Originally posted by @kontura in #1280 (comment)

@kontura kontura changed the title dnf5 offline-distrosync does offline-distrosync compatible subcommands Mar 20, 2024
@ppisar ppisar added RFE Request For Enhancement (as opposed to a bug) Priority: LOW labels Mar 21, 2024
@ppisar ppisar added this to DNF team Mar 21, 2024
@github-project-automation github-project-automation bot moved this to Backlog in DNF team Mar 21, 2024
@kontura
Copy link
Contributor Author

kontura commented Apr 2, 2024

Looks like this got reported twice: #1343 and its already completed.

@kontura kontura closed this as completed Apr 2, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in DNF team Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: LOW RFE Request For Enhancement (as opposed to a bug)
Projects
Archived in project
Development

No branches or pull requests

2 participants