Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let UART write return some bytes were written #838

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

jannic
Copy link
Member

@jannic jannic commented Aug 22, 2024

embedded_io::Write::write(buf) should not block until the full buffer was written. Instead, it should only block until at least one byte was written.

(See #837 (comment))

embedded_io::Write::write(buf) should not block until the full buffer
was written. Instead, it should only block until at least one byte
was written.
@thejpster
Copy link
Member

Fixes #840

Copy link
Member

@thejpster thejpster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self to also fix RP2350 HAL.

@thejpster thejpster merged commit 4e2f01c into rp-rs:main Aug 22, 2024
22 checks passed
jannic added a commit to jannic/rp-hal that referenced this pull request Aug 24, 2024
The updates from rp-rs#798, rp-rs#837 and rp-rs#838 were only applied to rp2040-hal.
This patch ports them to rp235x-hal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants