-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an RP2350 HAL. #834
Add an RP2350 HAL. #834
Conversation
Taken from https://github.com/thejpster/rp-hal-rp2350-public, with minor tweaks.
We can't build all the examples, so cargo udeps gets upset because no one example needs all the dependencies.
Hey, it finally completed all 98 jobs! |
Also remove references to RP2040 that I missed.
elf2uf2-rs doesn't work on RP2350. See JoNil/elf2uf2-rs#33
Of course changing the board name caused every comment to re-wrap.
Both examples had a copy-pasta description. That's now fixed.
Both examples had a typo in the comments.
Both examples had a typo in the description. That's now fixed.
Co-authored-by: 9names <[email protected]>
Co-authored-by: 9names <[email protected]>
OK I think I hit them all. RIP all those GHA free minutes. |
Some files got updates for rp2040 after you did the copy for rp235x. |
Lets do it the latter way, it would be better as smaller update PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple of copy-paste errors on datasheet URL but otherwise good to go
Co-authored-by: 9names <[email protected]>
Co-authored-by: 9names <[email protected]>
Yes, once this is in there's a lot of scope for de-duplication. I wasn't able to track the rp2040-hal whilst working in my private repo, so it sort of diverged. Then to open this PR I had to rebase a bunch of stuff and try and get closer to where you were (but you kept moving). I propose that after this goes in we do a |
Taken from https://github.com/thejpster/rp-hal-rp2350-public, with minor tweaks.