Deletes the top-level workspace and moves the examples. #828
Conversation
thejpster
force-pushed
the
move-examples-delete-workspace
branch
from
826cb98 to
7a63fc7
Compare
|
I'll rebase this Edit: done |
thejpster
force-pushed
the
move-examples-delete-workspace
branch
from
fa175fb to
b423208
Compare
rp2040-hal-examples/Cargo.toml
Outdated
| pio = "0.2.0" | ||
| pio-proc = "0.2.0" | ||
| rp2040-boot2 = "0.3.0" | ||
| rp2040-hal = { path = "../rp2040-hal", version = "0.10.0", features = ["binary-info", "critical-section-impl", "rt", "defmt"] } |
There was a problem hiding this comment.
Although It was an eyesore, I think it was a good thing to see what features each example required.
There was a problem hiding this comment.
Feature unification. The HAL is only built once and needs all the features set that are required by any bin. With examples it would just silently not build any examples when the required feature wasn't set, which I found frustrating (cargo build wouldn't build any examples, but cargo build --all-features would).
We could split each example into its own package, but that seems extreme.
Or I guess I could document each required feature at the top of each binary, but I've got no way of checking that that's correct.
There was a problem hiding this comment.
You are right. I found it nice that from a user experience, targeting a specific examples would tell "that examples requires those features".
But I’m fine with this as well.
Would it be good in the future to mutualize the examples and have a "portability"/"bsp" module in the example crate to map to either rp2040 or rp235x ?
There was a problem hiding this comment.
I think it's very unlikely that anyone wouldn't want the critical-section-impl or rt features. In particular, not using rt gives you a 'default' vector table which is broken and doesn't work. I'm also going to change all the examples so they include binary info by default, because it's just nice to have.
That leaves the 'defmt' feature. I could add a defmt feature to the examples package, and then mark the various binary crates within it that require the defmt feature in the HAL to require that feature to be set on the package.
thejpster
force-pushed
the
move-examples-delete-workspace
branch
from
f7adce8 to
b57d484
Compare
RP2350 stuff is coming, and you can't build rp2040-hal for Armv8-M and you can't build rp235x-hal for Armv6-M, and so they cannot be in the same workspace. Ergo, if the rp2350-hal is coming to this repo (and it is), we cannot have a workspace any more. I also moved the examples into their own package, because that's much neater than having to deal with memory.x being in magically the right place, or a bunch of dev-dependencies that are not relevant to most crate users.
Removes node.js deprecation notice.
Keys are now sorted, and all one-liners.
thejpster
force-pushed
the
move-examples-delete-workspace
branch
from
b57d484 to
fae6b25
Compare
RP2350 stuff is coming, and you can't build rp2040-hal for Armv8-M and you can't build rp235x-hal for Armv6-M, and so they cannot be in the same workspace. Ergo, if the rp2350-hal is coming to this repo (and it is), we cannot have a workspace any more.
I also moved the examples into their own package, because that's much neater than having to deal with memory.x being in magically the right place, or a bunch of dev-dependencies that are not relevant to most crate users.