Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript support #26

Open
joshua1 opened this issue Jun 3, 2021 · 4 comments
Open

Typescript support #26

joshua1 opened this issue Jun 3, 2021 · 4 comments

Comments

@joshua1
Copy link

joshua1 commented Jun 3, 2021

Hi @dominikg and @jakobrosenberg, 👍 first on this. I wanted to ask if there are any plans to include typescript support since routify and vite supports it , and give users the option to choose between TS or JS

@jakobrosenberg
Copy link
Member

I don't know enough about implementing Typescript to dynamic structures to know if this is possible. @lamualfa might know more about this.

@joshua1 is this something you'd be interested in maintaining if we can add it?

@joshua1
Copy link
Author

joshua1 commented Jun 3, 2021

@jakobrosenberg Thanks for the quick reply. I would be interested in maintaining it. I am actually going through the source , looking at how it can be included .

@jakobrosenberg
Copy link
Member

Sorry about the lack of documentation on the mechanics, if you have any questions feel free to ask here or on Discord. 🙂

@dominikg
Copy link
Collaborator

dominikg commented Jun 3, 2021

keep in mind that typescript requires more than just adding the dependencies. You need to transform existing js files to ts, maybe even add typings. svelte-preprocess and depending on other present fragments more stuff. some things might need to be done only for specific fragment combinations.

Havn't had a chance to check this out in depth, but my gut feeling is that you either need to do a complete split with something like stackmix-ts or have the ts fragment analyze what other fragments are present and then do it's thing.

Problems arise when ts fragment gets added later on. so A -> ts -> B.... now when adding B you need to rerun ts fragment to account for B special stuff ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants