Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elastic: "print" view truncates lines #9677

Open
2 tasks done
gcolpart opened this issue Oct 22, 2024 · 3 comments · May be fixed by #9692
Open
2 tasks done

Elastic: "print" view truncates lines #9677

gcolpart opened this issue Oct 22, 2024 · 3 comments · May be fixed by #9692
Labels
bug C: User Interface help wanted

Comments

@gcolpart
Copy link

Prerequisites

  • I have searched for duplicate or closed issues
  • I can recreate the issue with all plugins disabled

Describe the issue

When I click on "print a message", the CSS print view truncates lines in particular when I select zoom 200% in print settings.

I have a dirty hotfix with editing /usr/share/roundcube/skins/elastic/deps/bootstrap.min.css in section @media print{and replace:

@page{size:a3}body{min-width:992px !important}.container{min-width:992px !important}

with:

@page{size:a3}body{}.container{min-width:992px !important}

Note : my hotfix is inspired by issue #7732

What browser(s) are you seeing the problem on?

Firefox

What version of PHP are you using?

8.2

What version of Roundcube are you using?

1.6.5

JavaScript errors

No response

PHP errors

No response
@pabzm
Copy link
Member

pabzm commented Oct 23, 2024

Thank you for the bug report!

I can acknowledge the problem, but I wouldn't like to patch a third-party library.

Do you maybe can think of another way to fix this?

@gcolpart
Copy link
Author

I find a proper way to fix without patching bootstrap.css.

Just add to print.less :

@media print {
 body{
  min-width: auto !important;
 }
}

If you want see directly the result without rebuilding CSS, you can simply add to print.min.css :

@media print{body{min-width: auto !important}}

@pabzm
Copy link
Member

pabzm commented Oct 30, 2024

Ohh, great, thank you!

Would you create a pull request to propose this change?

(I can do that as well, but I don't want to take away your chance to contribute to Roundcubemail.)

gcolpart added a commit to gcolpart/roundcubemail that referenced this issue Nov 5, 2024
@gcolpart
Fix truncates lines in print view roundcube#9677
e919452
@gcolpart gcolpart linked a pull request Nov 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C: User Interface help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix truncates lines in print view #9677 gcolpart/roundcubemail
2 participants
@gcolpart @pabzm