From d8ee0714da984c040235af0a4d4c0a23e8512944 Mon Sep 17 00:00:00 2001
From: roubachof <jm.alfonsi@gmail.com>
Date: Fri, 5 Feb 2021 16:43:04 +0100
Subject: [PATCH] Stopped using Triggers for color updates

---
 Tabs/Tabs/BottomTabItem.xaml        | 66 ++++++++++++-----------------
 Tabs/Tabs/BottomTabItem.xaml.cs     | 16 +++++++
 Tabs/Tabs/UnderlinedTabItem.xaml    | 54 +++++++++++------------
 Tabs/Tabs/UnderlinedTabItem.xaml.cs | 12 ++++++
 4 files changed, 78 insertions(+), 70 deletions(-)

diff --git a/Tabs/Tabs/BottomTabItem.xaml b/Tabs/Tabs/BottomTabItem.xaml
index 3f5ebcf..7fa999c 100644
--- a/Tabs/Tabs/BottomTabItem.xaml
+++ b/Tabs/Tabs/BottomTabItem.xaml
@@ -1,11 +1,12 @@
 <?xml version="1.0" encoding="UTF-8" ?>
 
-<tabs:TabTextItem x:Class="Sharpnado.Tabs.BottomTabItem"
-                  xmlns="http://xamarin.com/schemas/2014/forms"
-                  xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
-                  xmlns:effects="clr-namespace:Sharpnado.Tabs.Effects"
-                  xmlns:tabs="clr-namespace:Sharpnado.Tabs"
-                  x:Name="RootLayout">
+<tabs:TabTextItem
+    x:Class="Sharpnado.Tabs.BottomTabItem"
+    xmlns="http://xamarin.com/schemas/2014/forms"
+    xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
+    xmlns:effects="clr-namespace:Sharpnado.Tabs.Effects"
+    xmlns:tabs="clr-namespace:Sharpnado.Tabs"
+    x:Name="RootLayout">
 
     <ContentView.Resources>
         <ResourceDictionary>
@@ -23,47 +24,32 @@
     </ContentView.Resources>
 
     <ContentView.Content>
-        <Grid x:Name="Grid"
-              BackgroundColor="Transparent"
-              ColumnSpacing="0"
-              RowSpacing="0">
+        <Grid
+            x:Name="Grid"
+            BackgroundColor="Transparent"
+            ColumnSpacing="0"
+            RowSpacing="0">
 
             <Grid.RowDefinitions>
                 <RowDefinition Height="8*" />
                 <RowDefinition x:Name="TextRowDefinition" Height="5*" />
             </Grid.RowDefinitions>
 
-            <Image x:Name="Icon"
-                   Grid.Row="0"
-                   Style="{StaticResource TabIcon}"
-                   WidthRequest="{Binding Source={x:Reference RootLayout}, Path=IconSize}"
-                   HeightRequest="{Binding Source={x:Reference RootLayout}, Path=IconSize}"
-                   effects:ImageEffect.TintColor="{Binding Source={x:Reference RootLayout}, Path=UnselectedIconColor}"
-                   Source="{Binding Source={x:Reference RootLayout}, Path=IconImageSource}">
-                <Image.Triggers>
-                    <DataTrigger Binding="{Binding Source={x:Reference RootLayout}, Path=IsSelected}"
-                                 TargetType="Image"
-                                 Value="true">
-                        <Setter Property="effects:ImageEffect.TintColor" Value="{Binding Source={x:Reference RootLayout}, Path=SelectedTabColor}" />
-                    </DataTrigger>
-                </Image.Triggers>
-            </Image>
+            <Image
+                x:Name="Icon"
+                Grid.Row="0"
+                HeightRequest="{Binding Source={x:Reference RootLayout}, Path=IconSize}"
+                Source="{Binding Source={x:Reference RootLayout}, Path=IconImageSource}"
+                Style="{StaticResource TabIcon}"
+                WidthRequest="{Binding Source={x:Reference RootLayout}, Path=IconSize}" />
 
-            <Label x:Name="IconText"
-                   Grid.Row="1"
-                   Style="{StaticResource TabIconLabel}"
-                   FontFamily="{Binding Source={x:Reference RootLayout}, Path=FontFamily}"
-                   FontSize="{Binding Source={x:Reference RootLayout}, Path=LabelSize}"
-                   Text="{Binding Source={x:Reference RootLayout}, Path=Label}"
-                   TextColor="{Binding Source={x:Reference RootLayout}, Path=UnselectedLabelColor}">
-                <Label.Triggers>
-                    <DataTrigger Binding="{Binding Source={x:Reference RootLayout}, Path=IsSelected}"
-                                 TargetType="Label"
-                                 Value="true">
-                        <Setter Property="TextColor" Value="{Binding Source={x:Reference RootLayout}, Path=SelectedTabColor}" />
-                    </DataTrigger>
-                </Label.Triggers>
-            </Label>
+            <Label
+                x:Name="IconText"
+                Grid.Row="1"
+                FontFamily="{Binding Source={x:Reference RootLayout}, Path=FontFamily}"
+                FontSize="{Binding Source={x:Reference RootLayout}, Path=LabelSize}"
+                Style="{StaticResource TabIconLabel}"
+                Text="{Binding Source={x:Reference RootLayout}, Path=Label}" />
         </Grid>
     </ContentView.Content>
 </tabs:TabTextItem>
\ No newline at end of file
diff --git a/Tabs/Tabs/BottomTabItem.xaml.cs b/Tabs/Tabs/BottomTabItem.xaml.cs
index 94234cf..a6aadbf 100644
--- a/Tabs/Tabs/BottomTabItem.xaml.cs
+++ b/Tabs/Tabs/BottomTabItem.xaml.cs
@@ -1,5 +1,7 @@
 using System.Runtime.CompilerServices;
 
+using Sharpnado.Tabs.Effects;
+
 using Xamarin.Forms;
 using Xamarin.Forms.Xaml;
 
@@ -41,6 +43,7 @@ public BottomTabItem()
             LabelSize = 12;
 
             UpdateTextVisibility();
+            UpdateColors();
         }
 
         [TypeConverter(typeof(ImageSourceConverter))]
@@ -82,6 +85,13 @@ protected override void OnPropertyChanged([CallerMemberName] string propertyName
                 case nameof(IsTextVisible):
                     UpdateTextVisibility();
                     break;
+
+                case nameof(UnselectedLabelColor):
+                case nameof(UnselectedIconColor):
+                case nameof(SelectedTabColor):
+                case nameof(IsSelected):
+                    UpdateColors();
+                    break;
             }
         }
 
@@ -110,5 +120,11 @@ private void UpdateTextVisibility()
                 Icon.VerticalOptions = LayoutOptions.Center;
             }
         }
+
+        private void UpdateColors()
+        {
+            IconText.TextColor = IsSelected ? SelectedTabColor : UnselectedLabelColor;
+            ImageEffect.SetTintColor(Icon, IsSelected ? SelectedTabColor : UnselectedIconColor);
+        }
     }
 }
\ No newline at end of file
diff --git a/Tabs/Tabs/UnderlinedTabItem.xaml b/Tabs/Tabs/UnderlinedTabItem.xaml
index eae94d4..40875db 100644
--- a/Tabs/Tabs/UnderlinedTabItem.xaml
+++ b/Tabs/Tabs/UnderlinedTabItem.xaml
@@ -1,10 +1,11 @@
 <?xml version="1.0" encoding="UTF-8" ?>
 
-<tabs:TabTextItem x:Class="Sharpnado.Tabs.UnderlinedTabItem"
-                  xmlns="http://xamarin.com/schemas/2014/forms"
-                  xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
-                  xmlns:tabs="clr-namespace:Sharpnado.Tabs"
-                  x:Name="RootLayout">
+<tabs:TabTextItem
+    x:Class="Sharpnado.Tabs.UnderlinedTabItem"
+    xmlns="http://xamarin.com/schemas/2014/forms"
+    xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
+    xmlns:tabs="clr-namespace:Sharpnado.Tabs"
+    x:Name="RootLayout">
 
     <ContentView.Resources>
         <ResourceDictionary>
@@ -26,36 +27,29 @@
                 <RowDefinition Height="*" />
             </Grid.RowDefinitions>
 
-            <BoxView x:Name="Underline"
-                     HeightRequest="0"
-                     Margin="0,0"
-                     HorizontalOptions="Center"
-                     VerticalOptions="End"
-                     BackgroundColor="Transparent">
+            <BoxView
+                x:Name="Underline"
+                Margin="0,0"
+                BackgroundColor="Transparent"
+                HeightRequest="0"
+                HorizontalOptions="Center"
+                VerticalOptions="End">
                 <BoxView.Triggers>
-                    <DataTrigger Binding="{Binding Source={x:Reference RootLayout}, Path=IsSelected}"
-                                 TargetType="BoxView"
-                                 Value="true">
-                        <Setter Property="BackgroundColor" Value="{Binding Source={x:Reference RootLayout}, Path=SelectedTabColor}" />
+                    <DataTrigger
+                        Binding="{Binding Source={x:Reference RootLayout}, Path=IsSelected}"
+                        TargetType="BoxView"
+                        Value="true">
                         <Setter Property="HeightRequest" Value="{Binding Source={x:Reference RootLayout}, Path=UnderlineHeight}" />
                     </DataTrigger>
                 </BoxView.Triggers>
             </BoxView>
-            <Label x:Name="InnerLabel"
-                   Style="{StaticResource TabTextHeader}"
-                   HorizontalOptions="Center"
-                   FontFamily="{Binding Source={x:Reference RootLayout}, Path=FontFamily}"
-                   FontSize="{Binding Source={x:Reference RootLayout}, Path=LabelSize}"
-                   Text="{Binding Source={x:Reference RootLayout}, Path=Label}"
-                   TextColor="{Binding Source={x:Reference RootLayout}, Path=UnselectedLabelColor}">
-                <Label.Triggers>
-                    <DataTrigger Binding="{Binding Source={x:Reference RootLayout}, Path=IsSelected}"
-                                 TargetType="Label"
-                                 Value="true">
-                        <Setter Property="TextColor" Value="{Binding Source={x:Reference RootLayout}, Path=SelectedTabColor}" />
-                    </DataTrigger>
-                </Label.Triggers>
-            </Label>
+            <Label
+                x:Name="InnerLabel"
+                FontFamily="{Binding Source={x:Reference RootLayout}, Path=FontFamily}"
+                FontSize="{Binding Source={x:Reference RootLayout}, Path=LabelSize}"
+                HorizontalOptions="Center"
+                Style="{StaticResource TabTextHeader}"
+                Text="{Binding Source={x:Reference RootLayout}, Path=Label}" />
         </Grid>
     </ContentView.Content>
 </tabs:TabTextItem>
\ No newline at end of file
diff --git a/Tabs/Tabs/UnderlinedTabItem.xaml.cs b/Tabs/Tabs/UnderlinedTabItem.xaml.cs
index 774b54d..ca536b7 100644
--- a/Tabs/Tabs/UnderlinedTabItem.xaml.cs
+++ b/Tabs/Tabs/UnderlinedTabItem.xaml.cs
@@ -58,6 +58,12 @@ protected override void OnPropertyChanged([CallerMemberName] string propertyName
                 case nameof(UnderlineAllTab):
                     UpdateUnderlineAllTab();
                     break;
+
+                case nameof(UnselectedLabelColor):
+                case nameof(SelectedTabColor):
+                case nameof(IsSelected):
+                    UpdateColors();
+                    break;
             }
         }
 
@@ -100,5 +106,11 @@ private void UpdateMargin()
                 ? new Thickness(Underline.Margin.Left - Margin.Left, 0, Underline.Margin.Right - Margin.Right, 0)
                 : new Thickness(0);
         }
+
+        private void UpdateColors()
+        {
+            InnerLabel.TextColor = IsSelected ? SelectedTabColor : UnselectedLabelColor;
+            Underline.Color = SelectedTabColor;
+        }
     }
 }
\ No newline at end of file