Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gentoo pip rosdep entries #29948

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Remove gentoo pip rosdep entries #29948

merged 2 commits into from
Jun 22, 2021

Conversation

mabelzhang
Copy link
Contributor

@mabelzhang mabelzhang commented Jun 17, 2021

Per #29909, remove gentoo pip entries because pip installs on gentoo need to be done with --user, and rosdep does system installs, so pip entries won't work on Gentoo.
The correct way is to create overlays. Will create a ticket in ros/ros-overlay for these.

Package name:

Removed gentoo pip entries in the following keys:

python-cython-pip
python-multiprocess-pip
python-parameterized
python-pyqtgraph
python3-aio-pika-pip
python3-ansible-runner-pip
python3-jupyros-pip
python3-simple-pid-pip
python3-siphon-pip
python3-tilestache-pip
python3-vcstool

Package Upstream Source:

Purpose of using this:

See note at top.

Links to Distribution Packages

Notes on a few entries that are removed but might have alternatives:

Replaced parameterized in key python-parameterized.
There is a dev-python/parameterized for Python 3, now added to python3-parameterized key.
https://packages.gentoo.org/packages/dev-python/parameterized

Removed pyqtgraph in key python-pyqtgraph.
There is a dev-python/pyqtgraph for Python 3, and it is already in python3-pyqtgraph key.
https://packages.gentoo.org/packages/dev-python/pyqtgraph

Removed ansible-runner in key python3-ansible-runner-pip.
There is a dev-python/ansible-runner for Python 3, but since the rosdep key name is -pip, I didn’t add the system package there.
If someone wants it for gentoo, they might just have to add a new key for python3-ansible-runner.
https://packages.gentoo.org/packages/dev-python/ansible-runner

Removed siphon in key python3-siphon-pip.
There is a net-analyzer/siphon, but it doesn’t say what Python it’s for, and the website is currently not accessible, and there isn’t a non-pip siphon rosdep key, so I didn’t add it.
https://packages.gentoo.org/packages/net-analyzer/siphon

Replaced vcstool pip entry in python3-vcstool with vcstool system dependency.
https://index.ros.org/d/python3-vcstool/

Other entries are simply removed because I didn't find alternatives.

Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
@mabelzhang mabelzhang requested a review from a team as a code owner June 17, 2021 18:01
@mabelzhang mabelzhang requested a review from tfoote June 17, 2021 18:01
@mabelzhang mabelzhang added the rosdep Issue/PR is for a rosdep key label Jun 17, 2021
@mabelzhang
Copy link
Contributor Author

Issue created ros/ros-overlay#1020

@wjwwood wjwwood merged commit 7ffc717 into master Jun 22, 2021
@wjwwood wjwwood deleted the mabelzhang/remove_gentoo_pip branch June 22, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants