Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails on paths that contain backslashes (\) #3

Open
JesseTG opened this issue Jul 9, 2023 · 4 comments · Fixed by #4
Open

Fails on paths that contain backslashes (\) #3

JesseTG opened this issue Jul 9, 2023 · 4 comments · Fixed by #4
Assignees

Comments

@JesseTG
Copy link

JesseTG commented Jul 9, 2023

When using a build-directory input that contains a backslash, as is common on Windows, then the problem matcher will fail to install with a message similar to the following:

Run root-project/gcc-problem-matcher-improved@9d83f12b27a78210f0485fb188e08d94fa807a6d
  with:
    build-directory: D:\a\melonds-ds\melonds-ds/build
  env:
    BUILD_DIR: D:\a\melonds-ds\melonds-ds/build
    DIST_DIR: D:\a\melonds-ds\melonds-ds/build/dist
Error: Unable to process command '::add-matcher::D:\a\_actions\root-project\gcc-problem-matcher-improved\9d83f12b27a78210f0485fb188e08d94fa807a6d\dist/gcc_matcher.json' successfully.
Error: Bad JSON escape sequence: \a. Path 'problemMatcher[0].pattern[0].regexp', line 7, position 36.
@Axel-Naumann
Copy link
Member

Thanks,I'll have a look! (We haven't used the problem matcher on Windows yet.)

@Axel-Naumann Axel-Naumann self-assigned this Aug 3, 2023
Axel-Naumann added a commit to Axel-Naumann/gcc-problem-matcher-improved that referenced this issue Aug 3, 2023
Axel-Naumann added a commit to Axel-Naumann/gcc-problem-matcher-improved that referenced this issue Aug 7, 2023
Axel-Naumann added a commit that referenced this issue Aug 7, 2023
@JesseTG
Copy link
Author

JesseTG commented Aug 12, 2023

Thank you for looking into this. Unfortunately the problem persists:

Prepare all required actions
Getting action download info
Download action repository 'root-project/gcc-problem-matcher-improved@f570674bcaf59d17ec0e6ae3ee0d03f8d68c1989' (SHA:f570674bcaf59d17ec0e6ae3ee0d03f8d68c1989)
Getting action download info
Run ./.github/actions/deps
  with:
    build-dir: D:\a\melonds-ds\melonds-ds/build
    ccache: sccache
    ccache-cache-name: melondsds_libretro-win32-x86_64-Release
    runs-on: windows-latest
  env:
    BUILD_DIR: D:\a\melonds-ds\melonds-ds/build
    DIST_DIR: D:\a\melonds-ds\melonds-ds/build/dist
Run root-project/gcc-problem-matcher-improved@f570674bcaf59d17ec0e6ae3ee0d03f8d68c1989
  with:
    build-directory: D:\a\melonds-ds\melonds-ds/build
  env:
    BUILD_DIR: D:\a\melonds-ds\melonds-ds/build
    DIST_DIR: D:\a\melonds-ds\melonds-ds/build/dist
Error: Unable to process command '::add-matcher::D:\\a\\_actions\\root-project\\gcc-problem-matcher-improved\\f570674bcaf59d17ec0e6ae3ee0d03f8d68c1989\\dist\\gcc_matcher.json' successfully.
Error: Bad JSON escape sequence: \a. Path 'problemMatcher[0].pattern[0].regexp', line 7, position 36.

@Axel-Naumann
Copy link
Member

Well, thank you for trying! Next I will try with forward slashes; if that still doesn't work I'll try with twice the amount of backslashes. It's gotta be possible somehow :-) Bear with me, please! And thanks for your feedback!

@JesseTG
Copy link
Author

JesseTG commented Aug 15, 2023

No problem, thanks for the useful tool!

@Axel-Naumann Axel-Naumann reopened this Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants