We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zipcode patterns are documented as generated from http://i18napis.appspot.com, which does not work anymore. I assume that this is similar to the data available at https://chromium-i18n.appspot.com/ssl-address for the libaddressinput of google.
When looking at the Java library for libaddressinput which consumes this data, the zipcode is matched case insensitively: https://github.com/google/libaddressinput/blob/2610f7b1043d6784ada41392fc9392d1ea09ea07/common/src/main/java/com/google/i18n/addressinput/common/FieldVerifier.java#L156-L163
This library performs case sensitive matching in
IsoCodes/src/IsoCodes/ZipCode.php
Line 228 in bf815ea
Would it make sense to update the implementation to match the behavior of libaddressinput ?
The text was updated successfully, but these errors were encountered:
@ronanguilloux any news here? would you accept a PR doing the change?
Sorry, something went wrong.
No branches or pull requests
Zipcode patterns are documented as generated from http://i18napis.appspot.com, which does not work anymore. I assume that this is similar to the data available at https://chromium-i18n.appspot.com/ssl-address for the libaddressinput of google.
When looking at the Java library for libaddressinput which consumes this data, the zipcode is matched case insensitively: https://github.com/google/libaddressinput/blob/2610f7b1043d6784ada41392fc9392d1ea09ea07/common/src/main/java/com/google/i18n/addressinput/common/FieldVerifier.java#L156-L163
This library performs case sensitive matching in
IsoCodes/src/IsoCodes/ZipCode.php
Line 228 in bf815ea
Would it make sense to update the implementation to match the behavior of libaddressinput ?
The text was updated successfully, but these errors were encountered: