Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support testnet4 #1036

Closed
antonilol opened this issue May 10, 2024 · 9 comments
Closed

Feature: support testnet4 #1036

antonilol opened this issue May 10, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@antonilol
Copy link
Contributor

Bitcoin Core PR: bitcoin/bitcoin#29775
Maybe an update from the bitcoin crate is needed, but it could be that simply changing some constants (port, data dir, ...) can get it to work too

@antonilol antonilol added the enhancement New feature or request label May 10, 2024
@nikicat
Copy link

nikicat commented May 23, 2024

Draft patch for testnet4

@antonilol
Copy link
Contributor Author

That seems way too complicated, I think it would be best to wait for rust-bitcoin to add testnet4 support in some way, I see they are also improving the way networks are handled, see rust-bitcoin/rust-bitcoin#2749

@nikicat
Copy link

nikicat commented May 23, 2024

It's indeed complicated, but from my point of view, it's less complicated than refactoring rust-bitcoin and gives the working solution right now. I do not propose it as a PR though, I just wanted to leave the link here if someone needs it.

@romanz
Copy link
Owner

romanz commented May 24, 2024

Thanks for opening this issue!
I prefer to wait for proper Testnet4 support from rust-bitcoin/rust-bitcoin#2749.

@twofaktor
Copy link

https://github.com/bitcoin/bitcoin/releases/tag/v28.0

@romanz
Copy link
Owner

romanz commented Oct 13, 2024

rust-bitcoin/rust-bitcoin#2749 is being backported to 0.32.x by rust-bitcoin/rust-bitcoin#3453.

@antonilol
Copy link
Contributor Author

Note that because the backport may not be a breaking change, it will be slightly different (adds a Testnet4 enum variant to Network instead of a new TestnetVersion field in Network::Testnet), see rust-bitcoin/rust-bitcoin#3453 (comment)

@junderw
Copy link

junderw commented Oct 19, 2024

The backport got ACKed, so expect 0.32.4 soon-ish.

It will be backwards compatible unlike the new network API on master.

@romanz
Copy link
Owner

romanz commented Oct 29, 2024

Merged in #1104 - thanks @junderw!

@romanz romanz closed this as completed Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants