Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonJS plugin version bump to 26.0.0 causes build issue #1731

Closed
bpneal opened this issue Jun 5, 2024 · 4 comments
Closed

CommonJS plugin version bump to 26.0.0 causes build issue #1731

bpneal opened this issue Jun 5, 2024 · 4 comments

Comments

@bpneal
Copy link

bpneal commented Jun 5, 2024

Expected Behavior

Rollup Builds successfully with commonJs Plugin

Actual Behavior

On Build, build fails with error SyntaxError: The requested module 'glob' does not provide an export named 'default'

Additional Information

@shellscape
Copy link
Collaborator

#1695 introduced the change, and commonjs has the largest test suite in the repo. all tests and builds did pass. @younggglcy please work with @bpneal to triage this, see stackblitz link above.

@shellscape
Copy link
Collaborator

@bpneal for now I'd recommend downgrading to the last 25.x.x version.

@shellscape
Copy link
Collaborator

@bpneal I made a quick edit to the plugin and published 26.0.1. Please see if that resolves the issue on your end, I forked your stackblitz and it appeared to.

@bpneal
Copy link
Author

bpneal commented Jun 5, 2024

@shellscape Looks like it is now all working as expected

@bpneal bpneal closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants