Templatized base types now work with mock_interface #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Would you mind adding a test case, to prevent the bug returning n the future? |
When using a template base class as the parameter to `mock_interface`, the `IMPLEMENT_MOCKn()` macros fail to compile due to `typename` missing before the `decltype(..)::type` statement. Fixes rollbear#116 Signed-off-by: Robert Dailey <[email protected]>
rcdailey
force-pushed
the
implement-mock-typename
branch
from
7d2f00a to
d7e0b0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a template base class as the parameter to
mock_interface, theIMPLEMENT_MOCKn()macros fail to compile due to
typenamemissing before thedecltype(..)::typestatement.Fixes #116