Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rokit errors when the same tool name under a different author exists, and only one is installed #49

Open
filiptibell opened this issue Jul 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@filiptibell
Copy link
Collaborator

Consider the following situation:

  1. User has added lune-org/lune@version in a global manifest
  2. User has added filiptibell/lune@version in a project-specific manifest
  3. Only lune from the global manifest is installed by the user
  4. Try to run lune in the project-specific manifest

Rokit will now be managing lune and only has the version from lune-org installed - meaning that when a user tries to run it under the project, and it refers to a tool from a different author, it will fail to run. This is caused by the Rokit runner not automatically prompting for and installing the new tool when necessary:

// TODO: Prompt for trust and install tool if not already installed

Implementing the promt-trust-and-install mechanism here in the runner will fix the issue.

@filiptibell filiptibell added the bug Something isn't working label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant