-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta 2 way sync #618
Open
Boegie19
wants to merge
10
commits into
rojo-rbx:master
Choose a base branch
from
Boegie19:meta-2-way-sync
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Meta 2 way sync #618
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d57d270
init 2 way sync meta
Boegie19 dce55c8
Fixed issues
Boegie19 d6ea59a
Removed print statements
Boegie19 b4c764e
forogt 1 print
Boegie19 92435e6
changed else { if to else if
Boegie19 b658d73
Merge branch 'rojo-rbx:master' into meta-2-way-sync
Boegie19 112fb47
better meta.json finder implementation
Boegie19 7ac2eb3
Merge branch 'meta-2-way-sync' of https://github.com/Boegie19/rojo in…
Boegie19 39ed263
add attributes to new AdjacentMetadata
Boegie19 b856e1d
remove debug stuff
Boegie19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally not sure if this is good enough if we where to add a new path to relevant_paths for some reason this would break
solution would be to add a special field to metadata for meta files. still this would make this change a lot lager.