Meta 2 way sync #618
Open
Meta 2 way sync #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boegie19
commented
Aug 9, 2022
src/change_processor.rs
Outdated
| @@ -244,7 +245,45 @@ impl JobThreadContext { | |||
| ); | |||
| } | |||
| } else { | |||
| log::warn!("Cannot change properties besides BaseScript.Source."); | |||
| if instance.metadata().relevant_paths.len() >= 2 { | |||
There was a problem hiding this comment.
I personally not sure if this is good enough if we where to add a new path to relevant_paths for some reason this would break
solution would be to add a special field to metadata for meta files. still this would make this change a lot lager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 way sync support for meta files.
if you change properties on a instance that is synced with rojo it would create/update the meta.js file for that one. with what you changed in studio.