This repository has been archived by the owner on Jan 24, 2020. It is now read-only.
notify: keep rescaled images around #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that at least dunst removes the image from the notification if the file disappears.
|
Split from #4 in case it isn't needed. |
|
I still don't see any sense in tmpfiles not getting cleaned up any time, even in .cache directories. But on second thought, I suggest that we keep the tmpfile around so dunst can display it, but write to the same tmpfile when a new notification is displayed on track change. We can then delete the tmpfile in |
|
I think that would just make all album images appear the same. I'm fine with a local patch until dunst gets a proper fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that at least dunst removes the image from the notification if
the file disappears.