From 2cc4aec4d0c887ddca4ecfb32abacfc7f900a1ac Mon Sep 17 00:00:00 2001
From: Rodolfo Picoreti <rodolfo.picoreti@gmail.com>
Date: Fri, 22 Feb 2019 12:04:58 -0300
Subject: [PATCH] revert version/id they cant be properties, add readme.

---
 README.md                     | 27 +++++++++++++++++++++++++++
 customer-service-api/pom.xml  | 10 +++++-----
 customer-service-impl/pom.xml | 20 ++++++++++----------
 pom.xml                       | 14 ++++++--------
 4 files changed, 48 insertions(+), 23 deletions(-)
 create mode 100644 README.md

diff --git a/README.md b/README.md
new file mode 100644
index 0000000..cca3b54
--- /dev/null
+++ b/README.md
@@ -0,0 +1,27 @@
+
+### Project Structure
+
+- customer-service-api: Java package defining only the interfaces and the models of the service. 
+This package can be consumed by clients in order to use this service (see CustomerClient for an example).
+- customer-service-impl: Java package containing the service implementation.
+
+### Maven
+
+Build (and test project)
+```bash
+./mvnw clean install
+# or
+./mvnw clean install -DskipTests
+```
+
+Run spring application for development
+```bash
+./mvnw -pl customer-service-impl spring-boot:run
+```
+
+Build image and add it to your docker daemon
+```bash
+./mvnw -pl customer-service-impl compile jib:dockerBuild
+```
+
+
diff --git a/customer-service-api/pom.xml b/customer-service-api/pom.xml
index 1456961..935897c 100644
--- a/customer-service-api/pom.xml
+++ b/customer-service-api/pom.xml
@@ -6,15 +6,15 @@
 
 	<parent>
 		<groupId>br.com.wine</groupId>
-		<artifactId>${service.name}</artifactId>
-		<version>${service.version}</version>
+		<artifactId>customer-service</artifactId>
+		<version>0.0.1-SNAPSHOT</version>
 	</parent>
 
 	<groupId>br.com.wine.service</groupId>
-	<artifactId>${service.name}-api</artifactId>
+	<artifactId>customer-service-api</artifactId>
 	<version>0.0.1-SNAPSHOT</version>
-	<name>${service.name}-api</name>
-	<description>${service.name} API definitions</description>
+	<name>customer-service-api</name>
+	<description>customer-service API definitions</description>
 
 	<dependencies>
 		<dependency>
diff --git a/customer-service-impl/pom.xml b/customer-service-impl/pom.xml
index 974cd12..1b77b65 100644
--- a/customer-service-impl/pom.xml
+++ b/customer-service-impl/pom.xml
@@ -6,21 +6,21 @@
 
 	<parent>
 		<groupId>br.com.wine</groupId>
-		<artifactId>${service.name}</artifactId>
-		<version>${service.version}</version>
+		<artifactId>customer-service</artifactId>
+		<version>0.0.1-SNAPSHOT</version>
 	</parent>
 
 	<groupId>br.com.wine.service</groupId>
-	<artifactId>${service.name}-impl</artifactId>
-	<version>${service.version}</version>
-	<name>${service.name}-impl</name>
-	<description>${service.name} service implementation</description>
+	<artifactId>customer-service-impl</artifactId>
+	<version>0.0.1-SNAPSHOT</version>
+	<name>customer-service-impl</name>
+	<description>customer-service service implementation</description>
 
 	<dependencies>
 		<dependency>
 			<groupId>br.com.wine.service</groupId>
-			<artifactId>${service.name}-api</artifactId>
-			<version>${service.version}</version>
+			<artifactId>customer-service-api</artifactId>
+			<version>0.0.1-SNAPSHOT</version>
 		</dependency>
 
 		<dependency>
@@ -77,10 +77,10 @@
 				<version>1.0.0</version>
 				<configuration>
 					<from>
-						<image>gcr.io/distroless/java:${java.version</image>
+						<image>gcr.io/distroless/java:${java.version}</image>
 					</from>
 					<to>
-						<image>winecombr/${service.name}:${service.version}</image>
+						<image>winecombr/customer-service:${project.version}</image>
 					</to>
 				</configuration>
 			</plugin>
diff --git a/pom.xml b/pom.xml
index 6378df3..d19af4b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -12,8 +12,6 @@
 	</parent>
 
 	<properties>
-		<service.name>customer-service</service.name>
-		<service.version>0.0.1-SNAPSHOT</service.version>
 		<java.version>11</java.version>
 		<maven.compiler.source>${java.version}</maven.compiler.source>
 		<maven.compiler.target>${java.version}</maven.compiler.target>
@@ -21,14 +19,14 @@
 	</properties>
 
 	<groupId>br.com.wine</groupId>
-	<artifactId>${service.name}</artifactId>
-	<version>${service.version}</version>
-	<name>${service.name}</name>
-	<description>${service.name} project</description>
+	<artifactId>customer-service</artifactId>
+	<version>0.0.1-SNAPSHOT</version>
+	<name>customer-service</name>
+	<description>customer-service project</description>
 	<packaging>pom</packaging>
 
 	<modules>
-		<module>${service.name}-api</module>
-		<module>${service.name}-impl</module>
+		<module>customer-service-api</module>
+		<module>customer-service-impl</module>
 	</modules>
 </project>