Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch openssl for phpseclib #263

Open
joonlabs opened this issue Sep 10, 2024 · 0 comments
Open

Switch openssl for phpseclib #263

joonlabs opened this issue Sep 10, 2024 · 0 comments

Comments

@joonlabs
Copy link

Hey @robrichards,

thank you very much for providing this important library. It is used in many different other libraries - for example by the SAML2 library SAML-Toolkits/php-saml. Requirements on SAML have changed a lot in the past couple of years and many PHP developers find themselves in the situation, where the IDPs require algoithms like http://www.w3.org/2007/05/xmldsig-more#sha256-rsa-MGF1, that are not supported by the openssl biding in PHP in the current version, which is based on PKCS #1 v1.5:

Currently in PHP it is only possible to make and verify OpenSSL based signatures based on cryptography defined in PKCS #1 v1.5.

(see. https://bugs.php.net/bug.php?id=80495&edit=3)

Since there is no update of the binding planned, I wanted to quickly check and ask if you accept a rewrite of the openssl methods using the phpseclib/phpseclib library. I would offer to change the implementation and create a pull request. I am not asking to change the methods or the structure of the library but only to switch from the openssl implementation to the phpseclib one. This would enable the additional support for the missing RSA OAEP and MFG algorithms by keeping the other encryption algorithms at the same time.

We are currently switching out this library by an internal fork which does exactly that, because the Elster IDP of the german government we connect to (using the SAML library mentioned above) only supports the http://www.w3.org/2007/05/xmldsig-more#sha256-rsa-MGF1 algorithm. It would be awesome if this library would keep up with modern algorithms and enable developers SAML bindings to modern IDPs.

Looking forward to your answer,
Julius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant