Added Inference IDs to Sources when Uploaded via the Dataset Upload Block #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlersupple
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby,
probicheaux and
hansent
as code owners
| @@ -457,13 +457,19 @@ def register_datapoint( | |||
| batch_name: str, | |||
| tags: List[str], | |||
| ) -> str: | |||
| inference_id = ( | |||
There was a problem hiding this comment.
Could u please put todo comment linking this issue: #567
PawelPeczek-Roboflow
approved these changes
Aug 8, 2024
PawelPeczek-Roboflow
requested changes
Aug 8, 2024
PawelPeczek-Roboflow
requested changes
Aug 9, 2024
PawelPeczek-Roboflow
added a commit
that referenced
this pull request
Aug 9, 2024
|
Updated my branch with your changes fixing issues I spotted and adding tests: 0962acd @chandlersupple please verify + suggestion for next contribution - if you change behaviour of code such that you add / remove parameter and this is somewhat important change you shall expect some test to fail - if that's not the case and you care about change you should modify existing tests / add new test to ensure coverage |
|
to be closed soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an image is uploaded through Active Learning, Model Monitoring allows users to view the image in its "Recent Inferences" table. This currently works with Active Learning, however, it does not work with the new "Roboflow Dataset Upload" block in Workflows.
Modified the Dataset Upload block to provide the
inference_idtoregister_image_at_roboflow()(As is currently being done in Active Learning).Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Any specific deployment considerations
N/A
Docs
N/A