Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage fails with 2018 edition #51

Closed
hntd187 opened this issue Dec 25, 2018 · 4 comments
Closed

Coverage fails with 2018 edition #51

hntd187 opened this issue Dec 25, 2018 · 4 comments

Comments

@hntd187
Copy link

hntd187 commented Dec 25, 2018

I'm not exactly sure what is happening here, but it looks like doing a cargo update and then doing coverage in our CI build is broken by a dependency update. I can't tell if it's cargo-travis or our build somehow breaking it.

https://travis-ci.org/toshi-search/Toshi/jobs/471994844#L1634
@roblabla
Copy link
Owner

This is due to cargo-travis using a very old version of cargo-as-a-library.

@roblabla roblabla mentioned this issue Dec 25, 2018
Open
@roblabla
Copy link
Owner

Permanent fix would be #52. In the meantime, I'll update the cargo dependency.

@kurnevsky kurnevsky mentioned this issue Jan 10, 2019
Merged
@roblabla
Copy link
Owner

Fixed with #54

@roblabla
Copy link
Owner

0.0.10 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblabla @hntd187