Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle lack of debug symbols in the test profile #19

Open
roblabla opened this issue Oct 17, 2017 · 3 comments
Open

Handle lack of debug symbols in the test profile #19

roblabla opened this issue Oct 17, 2017 · 3 comments

Comments

@roblabla
Copy link
Owner

roblabla commented Oct 17, 2017

Reported by @debris at #18 (comment)

just one more question. The crate is working fine for me at ethabi repo, but I have problems with the other repo, which has slightly different project structure. pr: debris/tiny-keccak#19 coveralls report: https://coveralls.io/builds/13753308 coveralls reports that no files were covered

@roblabla
Copy link
Owner Author

roblabla commented Oct 17, 2017

kcov relies on debug symbols (and probably a sane optimization level) to do its work, but you are removing debug symbols and setting opt-level to 3 in the test profile, which cargo-travis uses : https://github.com/debris/tiny-keccak/blob/master/Cargo.toml#L19

When I set debug = true in the test profile, I managed to get a coverage report.

I should probably make it error hard with a good error message when it fails this way.

@roblabla roblabla changed the title tiny-keccak has no coverage report Handle lack of debug symbols in the test profile Oct 17, 2017
@debris
Copy link

debris commented Oct 18, 2017

you are absolutely right, thank you!

@roblabla
Copy link
Owner Author

Investingating some old issues. We currently have some code injecting -C debuginfo=2 when built with --release. I think unconditionally injecting -C debuginfo=2 would fix this problem for good.

https://github.com/roblabla/cargo-travis/blob/master/src/lib.rs#L36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants