Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 0.4.10 of micromodal #6

Closed
Holf opened this issue Feb 5, 2024 · 6 comments · Fixed by #8
Closed

Update to version 0.4.10 of micromodal #6

Holf opened this issue Feb 5, 2024 · 6 comments · Fixed by #8

Comments

@Holf
Copy link
Contributor

Holf commented Feb 5, 2024

I have been coming up against this issue: ghosh/Micromodal#489 (comment)

As stated in that comment, the issue does not happen with version 0.4.10 of micromodal. Perhaps svelte-micromodal could be updated to use this later version?

In the meantime, I have been able to force use of the later version by adding this to my package.json file:

"overrides": {
    "micromodal": "0.4.10"
},
@Holf Holf changed the title Update to version 0.4.10 of MicroModal Update to version 0.4.10 of micromodal Feb 5, 2024
@robinmetral
Copy link
Owner

Hey @Holf, sure! Glad that you could test this on your end and can confirm that 0.4.10 works. Can you make a PR for this?

Otherwise I'll fix it, but since I'm on the road I'll need a few days (I can probably release a new version by the end of next week).

Thanks!

@robinmetral
Copy link
Owner

We just need to make sure that this doesn't happen with 0.4.10: ghosh/Micromodal#490

This was the reason I pinned the version initially. To be honest I haven't really followed the issue thread, not sure whether it was fixed in the end

@Holf
Copy link
Contributor Author

Holf commented Feb 10, 2024

Hello! Thanks for the reply. I would gladly have done a PR but it looks to me as though that issue has not been fixed (excellent bug report, btw!).

There are some suggestions in that thread for fixes to Micromodal itself, and also some work-arounds in this and another thread. I wouldn't want to push ahead and implement anything without getting your thoughts on it, first.

@robinmetral
Copy link
Owner

robinmetral commented Feb 16, 2024

Thanks! 😊

I'm completely okay with any fix you think would make sense here. This one for example would be a breaking change (changes to markup), but since this is in beta, I think we're good and I could release this in a v0.0.9 with a BREAKING CHANGE mention.

Do you want to make a PR? I'd gladly review and accept it 🙂

@Holf
Copy link
Contributor Author

Holf commented Feb 16, 2024

Cool, after a quick look through the ideas that layout-change suggestion was the one that jumped out to me, too. 😎

I'll have a look at doing a PR, for sure.

@robinmetral
Copy link
Owner

The micromodal version was unpinned (and upgraded) in [email protected]. Thank you @Holf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants