-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to version 0.4.10 of micromodal #6
Comments
Hey @Holf, sure! Glad that you could test this on your end and can confirm that 0.4.10 works. Can you make a PR for this? Otherwise I'll fix it, but since I'm on the road I'll need a few days (I can probably release a new version by the end of next week). Thanks! |
We just need to make sure that this doesn't happen with 0.4.10: ghosh/Micromodal#490 This was the reason I pinned the version initially. To be honest I haven't really followed the issue thread, not sure whether it was fixed in the end |
Hello! Thanks for the reply. I would gladly have done a PR but it looks to me as though that issue has not been fixed (excellent bug report, btw!). There are some suggestions in that thread for fixes to |
Thanks! 😊 I'm completely okay with any fix you think would make sense here. This one for example would be a breaking change (changes to markup), but since this is in beta, I think we're good and I could release this in a Do you want to make a PR? I'd gladly review and accept it 🙂 |
Cool, after a quick look through the ideas that layout-change suggestion was the one that jumped out to me, too. 😎 I'll have a look at doing a PR, for sure. |
The micromodal version was unpinned (and upgraded) in [email protected]. Thank you @Holf! |
I have been coming up against this issue: ghosh/Micromodal#489 (comment)
As stated in that comment, the issue does not happen with version
0.4.10
ofmicromodal
. Perhapssvelte-micromodal
could be updated to use this later version?In the meantime, I have been able to force use of the later version by adding this to my
package.json
file:The text was updated successfully, but these errors were encountered: