Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio 2017 Build Support #335

Open
Reelix opened this issue Feb 25, 2018 · 1 comment
Open

Visual Studio 2017 Build Support #335

Reelix opened this issue Feb 25, 2018 · 1 comment

Comments

@Reelix
Copy link

Reelix commented Feb 25, 2018

Attempting to compile in Visual Studio 2017 gives the "unknown compiler" error. This is because string_s.h does not support it.

Copying the 2015 one and simply changing the _MSC_VER check to VS2017's one - 1912 - Gets it to compile, but I'm unsure of how the other variables parameters are calculated.
@sgt53
Copy link

sgt53 commented Sep 23, 2018

#374 Resolves this issue.

@sgt53 sgt53 mentioned this issue Sep 23, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Reelix @sgt53