Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up by calculating shape functions once! #231

Closed
robbievanleeuwen opened this issue Jun 29, 2022 · 3 comments · Fixed by #293
Closed

Speed up by calculating shape functions once! #231

robbievanleeuwen opened this issue Jun 29, 2022 · 3 comments · Fixed by #293
Assignees
@robbievanleeuwen
Labels
enhancement New feature or request

Comments

@robbievanleeuwen
Copy link
Owner

We are constantly recalculating shape functions and associated values throughout a geometric & warping analysis. Would it be faster just to pre-calculate these on initialisation of the finite element and store them for use later?
@robbievanleeuwen robbievanleeuwen added the enhancement New feature or request label Jun 29, 2022
@robbievanleeuwen robbievanleeuwen self-assigned this Jun 29, 2022
@robbievanleeuwen
Copy link
Owner Author

Also add Tri3 elements and compare results!

@TLCFEM
Copy link
Contributor

TLCFEM commented Sep 27, 2023

It is possible to make shape function related funtions as methods of element class. The result can be cached based on the input coordinates. I can make the changes if you do not mind?

@robbievanleeuwen
Copy link
Owner Author

Hi @TLCFEM, happy for you to put together a PR for review 🚀

@robbievanleeuwen robbievanleeuwen linked a pull request Sep 30, 2023 that will close this issue
Add cache, improve performance #293
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robbievanleeuwen robbievanleeuwen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cache, improve performance
2 participants
@robbievanleeuwen @TLCFEM