Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up with multiprocessing #29

Open
robbievanleeuwen opened this issue Aug 4, 2022 · 4 comments
Open

Speed up with multiprocessing #29

robbievanleeuwen opened this issue Aug 4, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@robbievanleeuwen
Copy link
Owner

Is your feature request related to a problem? Please describe.
Biaxial bending diagrams and to a lesser extent, interaction diagrams, can take a long time to generate. Both of these features involve a number of independent calculations, currently implemented in a for loop.

Describe the solution you'd like
Using the python multiprocessing module would allow these computations to be performed in parallel on multiple cores, vastly speeding up these analyses.

@robbievanleeuwen robbievanleeuwen added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 4, 2022
@LunaCodeDemon
Copy link

I will work on it if you tell me in what file i should look and maybe even what function.
I won't test it, if anything isn't working afterwards you can inform me.

@robbievanleeuwen
Copy link
Owner Author

Hi @ChinoCodeDemon,

Sorry for the delayed response!

The two calculation loops that are expensive and could be computed in parallel are:

  1. Moment interaction diagram - loop starts here.
  2. Biaxial bending diagram - loop starts here.

I won't test it, if anything isn't working afterwards you can inform me.

Not sure what you mean by this, I would expect some effort is put into ensuring the implementation is robust, even if it's just a simple test that compares the results from the parallel method to those determined from a simple for loop, see contributing guidelines here.

@LunaCodeDemon
Copy link

LunaCodeDemon commented Aug 20, 2022

I cannot open a GUI since I work with containers.
I could implement some tests.

@LunaCodeDemon
Copy link

I created a draft pr #37 which still is heavily work in progress.
I will set it out of draft once everything is prove-able stable.

waynemaranga added a commit to waynemaranga/concrete-properties that referenced this issue Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants