Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device.py only has 60% test coverage #27

Open
thijstriemstra opened this issue Nov 3, 2017 · 3 comments
Open

device.py only has 60% test coverage #27

thijstriemstra opened this issue Nov 3, 2017 · 3 comments
Labels

Comments

@thijstriemstra
Copy link
Collaborator

thijstriemstra commented Nov 3, 2017

https://coveralls.io/builds/14034187/source?filename=luma%2Femulator%2Fdevice.py

@thijstriemstra thijstriemstra changed the title device.py only has 70% test coverage device.py only has 60% test coverage Nov 3, 2017
@rm-hull
Copy link
Owner

rm-hull commented Nov 3, 2017

This could be tricky to get higher coverage, as the bits that aren't tested are pygame and the asciiart emulators. Other than running them to make sure there are no errors, I'm not sure if there are any asserts that would make sense. Open to suggestions if you've got any ideas?

@thijstriemstra
Copy link
Collaborator Author

thijstriemstra commented Nov 3, 2017

you can use mock to fake these modules so we at least get the coverage.. (and catch the most obvious mistakes).

@thijstriemstra
Copy link
Collaborator Author

Looks like a branch for this ticket was started here: https://github.com/rm-hull/luma.emulator/tree/feature/test_coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants