API Workaround and enhancements

.gitignore

@@ -1,3 +1,4 @@
+.DS_Store
 /nbproject/private/
 /node_modules
 .brackets.json

src/calc2/main.tsx

@@ -67,7 +67,7 @@ export class Main extends React.Component<Props, State> {
 								<Redirect from="/relax/calc" to="/relax/calc/local/uibk/local/0" exact strict />
 								<Route path="/relax/calc/:source/:id/:filename/:index" component={ConnectedCalc} />
 								<Route path="/relax/calc/:source/:id" component={ConnectedCalc} />
-								<Route path="/relax/calc/:source/:id/:filename/:index" component={ConnectedCalc} />
+								<Route path="/relax/api/:source/:id/:filename/:index" component={ConnectedCalc} />
 								<Route path="/relax/api/:source/:id" component={ConnectedCalc} />
 								<Route render={match => (
 									<div className="view-min"><h1>404</h1>

src/calc2/store/groups.ts

@@ -68,16 +68,39 @@ export function* rootSaga() {
 				};
 				yield saga.put(success);
 				if (setCurrent !== undefined && loadedGroups.length > 0) {
-					const { source, id, filename } = loadedGroups[0].groupInfo;
-
-					const setCurrent: GROUP_SET_CURRENT = {
-						type: 'GROUP_SET_CURRENT',
-						source,
-						id,
-						filename,
-						index: 0,
-					};
-					yield saga.put(setCurrent);
+					// In case the :filename and :index are set in the URL,
+					// it's necessary to set the correct group accordingly
+					if (setCurrent && setCurrent != 'first' && 
+						setCurrent.filename && setCurrent.index) {
+						for(var i=0;i<loadedGroups.length;i++) {
+							const g = loadedGroups[i];
+							const { source, id, filename, index } = g.groupInfo;
+							if (filename == setCurrent.filename && index == setCurrent.index) {
+								const setCurrent: GROUP_SET_CURRENT = {
+									type: 'GROUP_SET_CURRENT',
+									source,
+									id,
+									filename,
+									index,
+								};
+								yield saga.put(setCurrent);
+								break;
+							}
+						}
+					}
+					// Otherwise, just try using the first group
+					else {
+						const { source, id, filename } = loadedGroups[0].groupInfo;
+
+						const setCurrent: GROUP_SET_CURRENT = {
+							type: 'GROUP_SET_CURRENT',
+							source,
+							id,
+							filename,
+							index: 0,
+						};
+						yield saga.put(setCurrent);
+					}
 				}
 			}
 			catch (e) {

src/calc2/utils/groupUtils.ts

@@ -178,7 +178,7 @@ export function loadGroupsFromSource(source: GroupSourceType, id: string, mainta
               reject(new Error('gist ' + id + ' not found'));
             },
           },
-          async: true,
+          async: false,
         });
         break;
       }

src/calc2/views/api.tsx

@@ -27,7 +27,12 @@ export class Api extends React.Component<Props, State> {
 	constructor(props: Props) {
 		super(props);
 		this.state = {};
-		this.query = atob(props.params.query)
+		// Fix issue of parsing + as a space
+		// https://www.npmjs.com/package/query-string
+		// https://github.com/sindresorhus/query-string/issues/305
+		// https://stackoverflow.com/questions/2678551/when-to-encode-space-to-plus-or-20
+		// https://stackoverflow.com/questions/3794919/replace-all-spaces-in-a-string-with
+		this.query = atob(props.params.query.split(' ').join('+'))
 	}
 
 	componentDidMount() {

src/calc2/views/calc.tsx

@@ -50,6 +50,11 @@ export class Calc extends React.Component<Props> {
 		})*/
 		this.apiView = this.props.location.pathname.split("/")[2] == "api"
 		this.params = queryString.parse(this.props.location.search)
+
+		// It's necessary to load remote group synchronouly
+		if (this.apiView) {
+			this.loadGroup(this.props);
+		}
 	}
 
 	componentDidUpdate(prevProps: Props): void {

src/calc2/views/help.tsx

@@ -2040,9 +2040,12 @@ export class Help extends React.Component<Props> {
 								</tr>
 
 								<tr>
-									<td><code>concat(a:string [, ...])</code></td>
+									<td><code>concat(a:"any" [, ...])</code></td>
 									<td>string</td>
-									<td>concatenates the given strings</td>
+									<td>returns the string that results from concatenating the arguments.
+										<br />May have one or more arguments. A non-string argument is implicitly converted to its equivalent string form and then concatenated. Returns null if any argument is null (like in <a
+								href="https://dev.mysql.com/doc/refman/8.0/en/string-functions.html#function_concat">MySQL</a>).
+									</td>
 								</tr>
 								<tr>
 									<td><code>upper(a:string)

src/db/exec/ValueExpr.ts

@@ -883,9 +883,9 @@ export class ValueExprGeneric extends ValueExpr {
 					if (this._dataType === 'null' && dataType !== 'null') {
 						this._dataTypeCalculated = dataType;
 					}
-					else if (dataType !== 'null' && this._dataType !== dataType) {
-						this.throwExecutionError(i18n.t('db.messages.exec.error-function-expects-arguments-of-same-type', {func: 'CONCAT()'}));
-					}
+					// else if (dataType !== 'null' && this._dataType !== dataType) {
+					// 	this.throwExecutionError(i18n.t('db.messages.exec.error-function-expects-arguments-of-same-type', {func: 'CONCAT()'}));
+					// }
 				}
 				break;
 			default: