Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity Engine 6.00 does not finish compiling #654

Open
ninpl opened this issue Nov 20, 2024 · 10 comments
Open

Unity Engine 6.00 does not finish compiling #654

ninpl opened this issue Nov 20, 2024 · 10 comments

Comments

@ninpl
Copy link

ninpl commented Nov 20, 2024

Hi, when importing package "Release 2024.8.0" into Unity Engine version "6000.0.23f1", the engine keeps compiling the files over and over again.

A temporary solution is to comment out the files:

  • Steamworks.NET/Editor/RedistCopy.cs
  • Steamworks.NET/Editor/RedistInstall.cs

I have verified that the functionality to create the steam_appid.txt file is executed, but it fails to create the DefineSymbols.
I'll check it out in depth when I have more time.

@ninpl
Copy link
Author

ninpl commented Nov 20, 2024

#602 Seems to fix it

@JamesMcGhee
Copy link
Contributor

Seeing this as well with the latest

Library\PackageCache\com.rlabrecque.steamworks.net\Editor\RedistInstall.cs(65,67): error CS0103: The name 'NamedBuildTarget' does not exist in the current context

@SSormunen
Copy link

I managed to quick fix "Library\PackageCache\com.rlabrecque.steamworks.net\Editor\RedistInstall.cs(65,67): error CS0103: The name 'NamedBuildTarget' does not exist in the current context" error by adding missing "using UnityEditor.Build" into the start of the RedistInstall.cs file.

@leonard4
Copy link

Unity 6 (6000.0.26f1) still has an infinite loop with the latest package installed from the git URL and with the fixes above for the RedistInstall.cs merge from, #602.

Only fix was to remove both Redist files when importing the unitypackage and copy the app id file by hand.

@SSormunen
Copy link

Unity 6 (6000.0.26f1) still has an infinite loop with the latest package installed from the git URL and with the fixes above for the RedistInstall.cs merge from, #602.

Only fix was to remove both Redist files when importing the unitypackage and copy the app id file by hand.

I'm also using 6000.0.26f1 and i dont have any infinite loops or other issues with building. Except that i needed to add that "using UnityEditor.Build" line in RedistInstall.cs

@JamesMcGhee
Copy link
Contributor

Same for me on 6000.0.25f1 all I needed was the using statement.

And I didn't need that until I updated Steamworks.NET
Not sure what changed but I imported Steamworks.NET a few weeks maybe a month ago and updated the project as you do.

Just today a user reported this issue so I updated Steamworks.NET to check and see if I could reproduce and yes ... yes I can

I looked at the change logs and didn't see anything that jumped out at me as a recent change that could cause this issue so it is a bit of a head-scratcher as to how/why this started.

The solution of adding statement though does correct the issue for me.

@rlabrecque
Copy link
Owner

rlabrecque commented Nov 25, 2024

Can one of you two make that PR? I'll check back and get it in ASAP.

I'll also try some of this out on multiple engine versions tonight.

@JamesMcGhee
Copy link
Contributor

Sure will do that in just a min

@JamesMcGhee
Copy link
Contributor

Done however check the note in that

So whatever caused this isn't Unity, it has to be some change to Steamworks.NET that was made in the past few days ... I didn't notice anything when I looked at the history of this file but I haven't looked to deeply past that.

Same issue happens on Unity 2022 with the current latest so the issue introduced has to be from a change made to Steamworks.NET in the past couple days. Its not a change that I noticed when I looked at the file history but its not specific to Unity v6000.x

@thejonliu
Copy link

I've ran into this issue, and my fix was to add STEAMWORKS_NET define/reset custom build profile to global.

For me, the issue was likely SetScriptingDefineSymbolsForGroup + ValveSoftware/steam-audio#384. I was using custom build profiles, so I'm guessing the continuous loop kept trying readd itself, but failing to add to the Custom profile, ad Infinitum.

I believe a potential long-term fix is either on Unity's side, or updating SetScriptingDefineSymbolsForGroup to some newer variant that considers build profiles. For a quick glance, didn't see anything super interesting, so I'm guessing this is more a Unity problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@leonard4 @rlabrecque @ninpl @SSormunen @JamesMcGhee @thejonliu and others