Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing glyph in develop_tab branch #3473

Closed
lpugin opened this issue Jul 3, 2023 · 7 comments
Closed

Missing glyph in develop_tab branch #3473

lpugin opened this issue Jul 3, 2023 · 7 comments

Comments

@lpugin
Copy link
Contributor

lpugin commented Jul 3, 2023

There is a missing glyph ornamentLeftVerticalStrokeWithCross used in the develop_tab branch.

fretStr = SMUFL_E595_ornamentLeftVerticalStrokeWithCross; // substitute for 1 with oblique stroke

It should be added to Leipzig first

@lpugin
Copy link
Contributor Author

lpugin commented Jul 3, 2023

Tagging @paul-bayleaf

@rettinghaus
Copy link
Contributor

This is a replacement glyph for the slashed number one:

Maybe it would make sense to use primitives for this (until SMuFL provides a proper glyph)?

@rettinghaus
Copy link
Contributor

@craigsapp how's that related?

@craigsapp
Copy link
Contributor

They have the same name 😉 The Compere Bassus first two measures are the same rhythm as the tablature (but I cannot read the tablature pitches so I don't know about that). The Josquin one has similar pitch contour as Compere but in a triple meter.

@paul-bayleaf
Copy link
Contributor

I'm preparing a pull request for the E-LAUTE project for vertical positioning of notes and rhythm signs and for @notationsubtype. I'll replace SMUFL_E595_ornamentLeftVerticalStrokeWithCross with a struck through digit 1 at the same time, so SMUFL_E595 won't be needed.

@paul-bayleaf
Copy link
Contributor

This issue can be closed, since #3512 was merged GLT no longer uses SMUFL_E595_ornamentLeftVerticalStrokeWithCross

@lpugin lpugin closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants