fix(ci): fix there is no reactor running in meta recovery tests, when kill-meta enabled #18852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwannoel
commented
Oct 11, 2024
| @@ -354,6 +354,7 @@ tokio-postgres = { git = "https://github.com/madsim-rs/rust-postgres.git", rev = | |||
| # If we can merge in: https://github.com/madsim-rs/sqlx/pull/2, | |||
| # we can change it to patch madsim version instead. | |||
| sqlx = { git = "https://github.com/kwannoel/sqlx.git", rev = "ddf222f56cf99f865231a5383053645c6ea05ba3" } | |||
| madsim = { git = "https://github.com/madsim-rs/madsim.git", rev = "f0ffd24864245aea236833f1ff3638f75bd51700" } | |||
There was a problem hiding this comment.
We can remove once madsim-rs/madsim#231 merged.
9 tasks
kwannoel
commented
Oct 11, 2024
| @@ -44,7 +44,7 @@ filter_stack_trace_for_all_logs() { | |||
| done | |||
| } | |||
|
|
|||
| trap filter_stack_trace_for_all_logs ERR | |||
| # trap filter_stack_trace_for_all_logs ERR | |||
There was a problem hiding this comment.
We can just remove the log filter, until recovery tests stabilize. The recent logs are < 1MB, and we only upload the zipped archive for the logs.
|
The original bug of I will just disable kill-meta in this branch, then we can merge it in, as the original branch is fixed from the patch. Disabling kill-meta is required since there are still bugs that occur semi-frequently, so we don't want to block other's PR workflows. |
kwannoel
force-pushed
the
kwannoel/enable-kill-meta-v2
branch
from
06f66b0 to
5c83d99
Compare
Closed
kwannoel
changed the title
Sounds good! |
BugenZhao
approved these changes
Oct 11, 2024
kwannoel
force-pushed
the
kwannoel/enable-kill-meta-v2
branch
from
5c83d99 to
930bb1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Apply patch: madsim-rs/madsim#231 which fixes an upstream bug: madsim-rs/madsim#228.
This patch fixes madsim-sqlx's drop on spawn error, and fixes one of the bugs in the meta recovery tests.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.