Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kinesis): bump aws-sdk-kinesis to 1.18.0 to fix creation failure #18702

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Sep 25, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

create table test (
    foo text
)
include offset as seq
with (
    connector='kinesis',
    aws.region='ap-southeast-1',
    aws.credentials.access_key_id='',
    aws.credentials.secret_access_key='',
    stream='test',
    scan.startup.mode='earliest'
)
format plain encode json;
ERROR:  Failed to run the query

Caused by these errors (recent errors listed first):
  1: gRPC request to meta service failed: Internal error
  2: failed to create source worker
  3: failed to list kinesis shards
  4: dispatch failure
  5: other
  6: UserAgentInterceptor modify_before_signing interceptor encountered an error
  7: The UserAgentInterceptor requires ApiMetadata to be set before the request is made. This is a bug. Please file an issue.

The above query failed on main. Upgrading aws-sdk-kinesis to 1.18.0 helps.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

stdrc commented Sep 25, 2024

@stdrc stdrc changed the title bump kinesis to 1.18 fix: bump kinesis to 1.18 Sep 25, 2024
@stdrc stdrc changed the title fix: bump kinesis to 1.18 fix: bump kinesis to 1.18.0 to fix creation failure Sep 25, 2024
@github-actions github-actions bot added type/fix Bug fix and removed Invalid PR Title labels Sep 25, 2024
@stdrc stdrc marked this pull request as ready for review September 25, 2024 07:19
@stdrc stdrc requested a review from a team as a code owner September 25, 2024 07:19
@stdrc stdrc requested a review from MrCroxx September 25, 2024 07:19
@stdrc stdrc changed the title fix: bump kinesis to 1.18.0 to fix creation failure fix(kinesis): bump kinesis to 1.18.0 to fix creation failure Sep 25, 2024
@stdrc stdrc requested a review from tabVersion September 25, 2024 07:21
@stdrc stdrc changed the title fix(kinesis): bump kinesis to 1.18.0 to fix creation failure fix(kinesis): bump aws-sdk-kinesis to 1.18.0 to fix creation failure Sep 25, 2024
@stdrc stdrc requested a review from xxchan September 25, 2024 08:05
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@stdrc stdrc added this pull request to the merge queue Sep 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2024
@stdrc stdrc added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 7f39b6a Sep 25, 2024
42 of 44 checks passed
@stdrc stdrc deleted the rc/fix-kinesis-source-creation branch September 25, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants