-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pg-cdc): fix support for partitioned table #18456
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
689547f
to
f032130
Compare
The fix in this PR works. However, due to a bug in sea-schema, CI fails. Their fix is here, which is included in The upgrading to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
...onnector-service/src/main/java/com/risingwave/connector/source/common/PostgresValidator.java
Outdated
Show resolved
Hide resolved
76f364a
to
709df33
Compare
07d9887
to
212d9df
Compare
212d9df
to
24b1f68
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The bug is found by user.
The bug contains two symptom:
publication
is created withoutpublish_via_partition_root = true
, the source/table creation will throw an error with messageERROR: relation "original_table" is already member of publication "rw_publication"
.publication
is created by RW, RW cannot get any data.The root cause is the
publish_via_partition_root = true
. Only with this option, the wal of each parition will be published in the root table's publication.The fix is inspired by https://groups.google.com/g/debezium/c/NroAVr2saxU/m/eSeS8hYXCwAJ
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
https://github.com/risingwavelabs/risingwave-docs/pull/2628