Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nimtable): fix decimal(28, 10) #18424

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Sep 5, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Convert RW decimal to iceberg decimal(28,10)
image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chenzl25 chenzl25 requested a review from a team as a code owner September 5, 2024 09:16
@chenzl25 chenzl25 requested a review from BugenZhao September 5, 2024 09:16
@chenzl25 chenzl25 changed the base branch from main to nimtable_dev September 5, 2024 09:16
@chenzl25 chenzl25 requested review from hzxa21, xxhZs, wenym1 and Li0k and removed request for BugenZhao and a team September 5, 2024 09:16
Copy link
Contributor

@xxhZs xxhZs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chenzl25 chenzl25 merged commit 4259d53 into nimtable_dev Sep 7, 2024
38 of 39 checks passed
@chenzl25 chenzl25 deleted the dylan/nimtable_fix_decimal branch September 7, 2024 08:57
chenzl25 added a commit that referenced this pull request Sep 20, 2024
chenzl25 added a commit that referenced this pull request Sep 20, 2024
chenzl25 added a commit that referenced this pull request Sep 20, 2024
chenzl25 added a commit that referenced this pull request Sep 20, 2024
chenzl25 added a commit that referenced this pull request Sep 20, 2024
chenzl25 added a commit that referenced this pull request Sep 25, 2024
chenzl25 added a commit that referenced this pull request Sep 26, 2024
Li0k pushed a commit that referenced this pull request Oct 14, 2024
Li0k pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants