Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ci): switch all tests to sql backend #18099

Merged
merged 41 commits into from
Oct 14, 2024
Merged

Conversation

yezizp2012
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel
Copy link
Contributor

Hi, before deprecating etcd backend, could we still keep their tests in main-cron still? Some users may continue using it and we won't deprecate etcd, at least in 2.0 I suppose.

@graphite-app graphite-app bot requested a review from a team August 26, 2024 05:04
@yezizp2012 yezizp2012 force-pushed the chore/switch-e2e-sql-backend branch from 8b31b8c to f135976 Compare August 26, 2024 09:42
@yezizp2012 yezizp2012 force-pushed the chore/switch-e2e-sql-backend branch from 1019c79 to f062a7e Compare August 29, 2024 06:05
@yezizp2012 yezizp2012 force-pushed the chore/switch-e2e-sql-backend branch from 2c55798 to a59de4c Compare September 20, 2024 08:00
@yezizp2012 yezizp2012 force-pushed the chore/switch-e2e-sql-backend branch from 17fefb6 to c0bb010 Compare October 10, 2024 05:13
Copy link

gitguardian bot commented Oct 11, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9425213 Triggered Generic Password d0c1525 e2e_test/source/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password d0c1525 e2e_test/source/tvf/postgres_query.slt View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@yezizp2012
Copy link
Member Author

yezizp2012 commented Oct 11, 2024

updates:
There's only one flaky test in end-to-end source test when running e2e_test/source/basic/kafka.slt . Meta will encounter Failed to acquire connection from pool: Connection pool timed out as follows (https://buildkite.com/risingwavelabs/pull-request/builds/59508#019274d8-9f15-4d75-aab9-d2d9c9678d06):

2024-10-10T05:31:58.00352696Z  WARN risingwave_meta::controller::cluster: Failed to load expire worker info from db error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:31:58.003630889Z  WARN risingwave_meta::hummock: Vacuum metadata error error=Hummock error: failed to access meta store: Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:32:28.005092227Z  WARN risingwave_meta::rpc::metrics: fail to list worker node error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:32:28.005118661Z  WARN risingwave_meta::rpc::metrics: fail to count worker node error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:32:58.006758545Z  WARN risingwave_meta::controller::cluster: Failed to load expire worker info from db error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:33:28.008841941Z  WARN risingwave_meta::rpc::metrics: fail to count worker node error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:33:28.008934887Z  WARN risingwave_meta::rpc::metrics: fail to list worker node error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:33:58.010520665Z  WARN risingwave_meta::controller::cluster: Failed to load expire worker info from db error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:33:58.010616525Z  WARN risingwave_meta::hummock: Vacuum metadata error error=Hummock error: failed to access meta store: Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:34:28.011121148Z  WARN risingwave_meta::rpc::metrics: fail to count worker node error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:34:28.011150804Z  WARN risingwave_meta::rpc::metrics: fail to list worker node error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:34:58.012202046Z  WARN risingwave_meta::controller::cluster: Failed to load expire worker info from db error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:35:28.013878678Z  WARN risingwave_meta::rpc::metrics: fail to count worker node error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:35:28.013962782Z  WARN risingwave_meta::rpc::metrics: fail to list worker node error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:35:58.015341782Z  WARN risingwave_meta::controller::cluster: Failed to load expire worker info from db error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:35:58.015431101Z  WARN risingwave_meta::hummock: Vacuum metadata error error=Hummock error: failed to access meta store: Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:36:28.016727587Z  WARN risingwave_meta::rpc::metrics: fail to count worker node error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:36:28.016763508Z  WARN risingwave_meta::rpc::metrics: fail to list worker node error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:36:58.018054737Z  WARN risingwave_meta::controller::cluster: Failed to load expire worker info from db error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:37:28.019971563Z  WARN risingwave_meta::rpc::metrics: fail to list worker node error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:37:28.019991183Z  WARN risingwave_meta::rpc::metrics: fail to count worker node error=Failed to acquire connection from pool: Connection pool timed out
2024-10-10T05:37:58.021876732Z  WARN risingwave_meta::controller::cluster: Failed to load expire worker info from db error=Failed to acquire connection from pool: Connection pool timed out

I'm still investigating. Should be fixed by #18885 .

@yezizp2012 yezizp2012 changed the title test[IGNORE ME]: switch all tests to sql backend test(ci): switch all tests to sql backend Oct 11, 2024
@yezizp2012 yezizp2012 added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit f299941 Oct 14, 2024
31 of 33 checks passed
@yezizp2012 yezizp2012 deleted the chore/switch-e2e-sql-backend branch October 14, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants